Skip to content

Fix wrong return value, added missing assertions, provide correct values for tested functions #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025

Conversation

tisnik
Copy link
Contributor

@tisnik tisnik commented May 25, 2025

Description

  • Fix wrong return value
  • Added missing assertions
  • Provide correct values for tested functions

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

@openshift-ci openshift-ci bot requested review from bparees and xrajesh May 25, 2025 16:35
@tisnik tisnik changed the title Fix wrong return value Fix wrong return value, added missing assertions, provide correct values for tested functions May 25, 2025
@tisnik tisnik force-pushed the fix-wrong-return-value branch from b43afbc to d4a4de6 Compare May 25, 2025 18:30
@tisnik
Copy link
Contributor Author

tisnik commented May 25, 2025

/test ci/prow/unit

Copy link

openshift-ci bot commented May 25, 2025

@tisnik: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 4.18-e2e-ols-cluster
/test 4.18-images
/test 4.18-ols-evaluation
/test fips-image-scan-service
/test images
/test integration
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-lightspeed-service-main-4.18-e2e-ols-cluster
pull-ci-openshift-lightspeed-service-main-4.18-images
pull-ci-openshift-lightspeed-service-main-fips-image-scan-service
pull-ci-openshift-lightspeed-service-main-images
pull-ci-openshift-lightspeed-service-main-integration
pull-ci-openshift-lightspeed-service-main-security
pull-ci-openshift-lightspeed-service-main-unit
pull-ci-openshift-lightspeed-service-main-verify

In response to this:

/test ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tisnik
Copy link
Contributor Author

tisnik commented May 25, 2025

/test unit

Copy link

openshift-ci bot commented May 25, 2025

@tisnik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tisnik
Copy link
Contributor Author

tisnik commented May 26, 2025

/approve

Copy link

openshift-ci bot commented May 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@JoaoFula
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6863925 into openshift:main May 26, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants