Refactor vgmanager #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
sp98
force-pushed
the
refactor-vgmanager
branch
2 times, most recently
from
ad0706a to
4462f14
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
nbalacha
suggested changes
Jan 11, 2022
| @@ -177,6 +175,46 @@ func (r *VGReconciler) reconcile(ctx context.Context, req ctrl.Request) (ctrl.Re | |||
| return ctrl.Result{RequeueAfter: requeueAfter}, nil | |||
| } | |||
|
|
|||
| func (r *VGReconciler) addDevicesToVG(vgName string, devices []internal.BlockDevice) error { | |||
| if len(devices) < 1 { | |||
| return fmt.Errorf("can't create vg with 0 devices") | |||
There was a problem hiding this comment.
Please add the vgname to this error.
pkg/vgmanager/lvm.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| return nil, fmt.Errorf("failed to unmarhsal volume group response. %v", err) |
| } | ||
|
|
||
| var cmd string | ||
| args := []string{vgName} |
There was a problem hiding this comment.
Do this after checking if the volume group is already present.
sp98
force-pushed
the
refactor-vgmanager
branch
2 times, most recently
from
542764d to
5a6ceec
Compare
nbalacha
approved these changes
Jan 12, 2022
|
Please correct the commit messages (formats) |
- Executor interface and its implementation helps to run os/exec commands Signed-off-by: Santosh Pillai <[email protected]>
- Use `json` response for easy parsing of lsblk output - use executor interface implementation Signed-off-by: Santosh Pillai <[email protected]>
- use `json` response for easy parsing. - use executor interface implementation Signed-off-by: Santosh Pillai <[email protected]>
sp98
force-pushed
the
refactor-vgmanager
branch
from
5a6ceec to
85a75d6
Compare
nbalacha
approved these changes
Jan 13, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nbalacha, sp98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os/execcommands. Helps to write unit tests using mocks.block deviceutility to use Executor interface andjsonresponse for easy parsing.jsonresponse for easy parsingTested changes on SNO-2: