Skip to content

OCPBUGS-42091: feat(controller): disable http2 #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

qJkee
Copy link
Contributor

@qJkee qJkee commented Sep 9, 2024

Disable http2 usage in all servers started
by controller manager

@openshift-ci-robot
Copy link

@qJkee: This pull request explicitly references no jira issue.

In response to this:

Disable http2 usage in all servers started
by controller manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2024
@qJkee
Copy link
Contributor Author

qJkee commented Sep 9, 2024

Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.63%. Comparing base (abffe3d) to head (69f0f35).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   70.20%   69.63%   -0.57%     
==========================================
  Files          48       49       +1     
  Lines        3262     3313      +51     
==========================================
+ Hits         2290     2307      +17     
- Misses        801      835      +34     
  Partials      171      171              

see 6 files with indirect coverage changes

@qJkee
Copy link
Contributor Author

qJkee commented Sep 10, 2024

/retest

Disable http2 usage in all servers started
by controller manager
@qJkee qJkee changed the title NO-JIRA: fix CVE-2024-8421 OCPBUGS-41616: fix CVE-2024-8421 Sep 10, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 10, 2024
@openshift-ci-robot
Copy link

@qJkee: This pull request references Jira Issue OCPBUGS-41616, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mmakwana30

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Disable http2 usage in all servers started
by controller manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mmakwana30 September 10, 2024 11:31
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8dfb37f into openshift:main Sep 10, 2024
10 checks passed
@openshift-ci-robot
Copy link

@qJkee: Jira Issue OCPBUGS-41616: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41616 has been moved to the MODIFIED state.

In response to this:

Disable http2 usage in all servers started
by controller manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qJkee
Copy link
Contributor Author

qJkee commented Sep 10, 2024

/cherry-pick release-4.17 release-4.16 release-4.15

@openshift-cherrypick-robot

@qJkee: new pull request created: #711

In response to this:

/cherry-pick release-4.17 release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@eggfoobar
Copy link

/retitle OCPBUGS-42091: feat(controller): disable http2

@openshift-ci openshift-ci bot changed the title OCPBUGS-41616: fix CVE-2024-8421 OCPBUGS-42091: feat(controller): disable http2 Sep 17, 2024
@openshift-ci-robot
Copy link

@qJkee: Jira Issue OCPBUGS-42091: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42091 has been moved to the MODIFIED state.

In response to this:

Disable http2 usage in all servers started
by controller manager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants