-
Notifications
You must be signed in to change notification settings - Fork 209
USHIFT-3477: Add explicit crun default runtime configuration for crio #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pacevedom: This pull request references USHIFT-3477 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -471,6 +474,9 @@ fi | |||
# Use Git command to generate the log and replace the VERSION string | |||
# LANG=C git log --date="format:%a %b %d %Y" --pretty="tformat:* %cd %an <%ae> VERSION%n- %s%n" packaging/rpm/microshift.spec | |||
%changelog | |||
* Wed Jun 12 2024 Pablo Acevedo Montserrat <[email protected]> 4.16.0 | |||
- Explicitly configure crun as default crio runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Explicitly configure crun as default crio runtime | |
- Explicitly configure crun as default CRI-O runtime |
@@ -404,6 +406,7 @@ fi | |||
%{_bindir}/microshift-cleanup-data | |||
%{_bindir}/microshift-sos-report | |||
%{_unitdir}/microshift.service | |||
%{_sysconfdir}/crio/crio.conf.d/00-crio-crun.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/approve |
@pacevedom, thank you for taking care of this! Appreciated. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwilczynski, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cherry-pick release-4.16 |
@pacevedom: new pull request created: #3477 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Which issue(s) this PR addresses:
Closes #