Skip to content

OCPBUGS-36587: Filter ip family in router service controller #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

pacevedom
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 5, 2024
@openshift-ci-robot
Copy link

@pacevedom: This pull request references Jira Issue OCPBUGS-36587, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 5, 2024
@pacevedom
Copy link
Contributor Author

/hold
Need to rebase to main after #3579 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2024
@openshift-ci openshift-ci bot requested review from jogeo and pmtk July 5, 2024 15:22
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
@pacevedom
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2024
@pacevedom
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 5, 2024
@openshift-ci-robot
Copy link

@pacevedom: This pull request references Jira Issue OCPBUGS-36587, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from ShudiLi July 5, 2024 21:28
@ShudiLi
Copy link
Member

ShudiLi commented Jul 8, 2024

/test verify

@ShudiLi
Copy link
Member

ShudiLi commented Jul 8, 2024

/label qe-approved

1.
% oc get node                                                 
NAME                                             STATUS   ROLES                         AGE     VERSION
i-0398ce375a93861c5.us-west-2.compute.internal   Ready    control-plane,master,worker   8m27s   v1.30.2
% oc debug node/i-0398ce375a93861c5.us-west-2.compute.internal

2.
sh-5.1# ip address | grep "inet6 " | egrep -v "::1|fe80"
    inet6 2600:1f14:d19:8c00:ec8b:c697:5f1a:1b63/128 scope global dynamic noprefixroute 
sh-5.1# ip address | grep "inet " | egrep -v "127|169"
    inet 10.192.10.116/24 brd 10.192.10.255 scope global dynamic noprefixroute eth0
    inet 10.44.0.0/32 scope global br-ex
    inet 10.42.0.2/24 brd 10.42.0.255 scope global ovn-k8s-mp0
sh-5.1#

3.
% oc -n openshift-ingress get svc
NAME                      TYPE           CLUSTER-IP     EXTERNAL-IP                         PORT(S)                      AGE
router-default            LoadBalancer   10.43.10.173   10.192.10.116,10.42.0.2,10.44.0.0   80:30503/TCP,443:31130/TCP   9m19s
router-internal-default   ClusterIP      10.43.94.243   <none>                              80/TCP,443/TCP,1936/TCP      9m19s
%

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 8, 2024
@openshift-ci-robot
Copy link

@pacevedom: This pull request references Jira Issue OCPBUGS-36587, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@pmtk pmtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 27a2e26 into openshift:main Jul 9, 2024
6 checks passed
@openshift-ci-robot
Copy link

@pacevedom: Jira Issue OCPBUGS-36587: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36587 has been moved to the MODIFIED state.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pacevedom pacevedom deleted the OCPBUGS-36587 branch July 9, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants