Skip to content

USHIFT-2596: improve TLS config cipher RF test cases #4479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

agullon
Copy link
Contributor

@agullon agullon commented Jan 28, 2025

  • Change TLSv1.2 default cipher to address OCPBUGS-48735: Fix default cipher suites when using TLS 1.2 #4451 change
  • Move OpenSSL command into an RF Keyword
  • Replace grep with Should Contain RF keyword to check expected command output
  • Checks for microshift show-config command
  • Check internal Kubernetes endpoints (kubelet, kube controller, kube scheduler and etcd)
  • Check all TLSv1.3 available cipher suites
  • Minor improvements and robustness changes

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2025

@agullon: This pull request references USHIFT-2596 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ggiguash and pmtk January 28, 2025 09:55
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@agullon
Copy link
Contributor Author

agullon commented Jan 28, 2025

/cc pacevedom

@openshift-ci openshift-ci bot requested a review from pacevedom January 28, 2025 09:57
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@agullon
Copy link
Contributor Author

agullon commented Jan 28, 2025

/retest-required

@agullon
Copy link
Contributor Author

agullon commented Jan 29, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2025

@agullon: This pull request references USHIFT-2596 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Change TLSv1.2 default cipher to address OCPBUGS-48735: Fix default cipher suites when using TLS 1.2 #4451 change
  • Move OpenSSL command into an RF Keyword
  • Replace grep with Should Contain RF keyword to check expected command output
  • Checks for microshift show-config command
  • Check internal Kubernetes endpoints (kubelet, kube controller, kube scheduler and etcd)
  • Check all TLSv1.3 available cipher suites
  • Minor improvements and robustness changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link
Contributor Author

agullon commented Jan 30, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2025
@agullon
Copy link
Contributor Author

agullon commented Jan 30, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2025
@agullon
Copy link
Contributor Author

agullon commented Jan 31, 2025

/hold
Blocked by #4495 PR
The failed test will pass when the blocked PR is merged

@pacevedom
Copy link
Contributor

/retest

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2025
Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agullon
Copy link
Contributor Author

agullon commented Feb 4, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
@agullon
Copy link
Contributor Author

agullon commented Feb 4, 2025

/retest

Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d10ca8d into openshift:main Feb 4, 2025
9 checks passed
@agullon
Copy link
Contributor Author

agullon commented May 21, 2025

/cherrypick release-4.19

@openshift-cherrypick-robot

@agullon: #4479 failed to apply on top of branch "release-4.19":

Applying: improve TLS config cipher RF test cases
Using index info to reconstruct a base tree...
A	test/suites/standard1/configuration.robot
Falling back to patching base and 3-way merge...
Auto-merging test/suites/standard2/configuration.robot
CONFLICT (content): Merge conflict in test/suites/standard2/configuration.robot
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 improve TLS config cipher RF test cases

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants