Skip to content

USHIFT-5491: Temporarily disable router security options tests #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

USHIFT-5491: Temporarily disable router security options tests #4690

merged 2 commits into from
Mar 18, 2025

Conversation

eslutsky
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 17, 2025
@openshift-ci-robot
Copy link

@eslutsky: This pull request explicitly references no jira issue.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ggiguash and vanhalenar March 17, 2025 13:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2025
@pacevedom pacevedom mentioned this pull request Mar 17, 2025
Closed
@openshift-merge-bot @eslutsky
Merge pull request openshift#4687 from pmtk/rhoai/fix-aws-script
31bbee7 
USHIFT-5339: Don't match ARM64 when instance type starts with 'g'
@eslutsky eslutsky force-pushed the skip-router-security-tests branch from b9ffd8a to 3ad0175 Compare March 17, 2025 13:51
pacevedom
pacevedom approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
@pacevedom
Copy link
Contributor

pacevedom commented Mar 17, 2025 •
edited by openshift-ci bot
Loading

/retitle USHIFT-5491: Temporarily disable router security options tests

@pacevedom
Copy link
Contributor

pacevedom commented Mar 17, 2025 •
edited by openshift-ci bot
Loading

/title USHIFT-5491: Temporarily disable router security options tests

@openshift-ci openshift-ci bot changed the title NO-ISSUE: Temporarily disable router security options tests USHIFT-5491: Temporarily disable router security options tests Mar 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2025 •
edited by openshift-ci bot
Loading

@eslutsky: This pull request references USHIFT-5491 which is a valid jira issue.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7ca542a and 2 for PR HEAD 3ad0175 in total

@eslutsky eslutsky force-pushed the skip-router-security-tests branch from 3ad0175 to 1e2fd64 Compare March 17, 2025 15:30
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2025
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [eslutsky,ggiguash,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a0daf0f into openshift:main Mar 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacevedom pacevedom pacevedom approved these changes

@ggiguash ggiguash Awaiting requested review from ggiguash

@vanhalenar vanhalenar Awaiting requested review from vanhalenar

Assignees

@pacevedom pacevedom

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eslutsky @openshift-ci-robot @pacevedom @ggiguash