context flag doesn't work properly for component create using --starter flag

[prietyc123]

/kind bug

What versions of software are you using?

Operating System:
All supported

Output of odo version:
master

How did you run odo exactly?

$ odo project create abcderf
 ✓  Project 'abcderf' is ready for use
 ✓  New project created and now using project: abcderf

$ odo create nodejs --starter --context ./testdis/
Validation
 ✓  Creating a devfile component from devfile path: /Users/pkumari/go/src/github.com/openshift/odo/testdis/devfile.yaml [67778ns]
 ✓  Validating devfile component [240338ns]
 ✗  Folder /Users/pkumari/go/src/github.com/openshift/odo is not empty. It can only contain the devfile used.

However when I tried the same step with changing the directory to ./testdis/ and run

$ odo create nodejs --starter --context .
Validation
 ✓  Creating a devfile component from devfile path: /Users/pkumari/go/src/github.com/openshift/odo/testdis/devfile.yaml [524522ns]
 ✓  Validating devfile component [1ms]

Starter Project
 ✓  Downloading starter project nodejs-starter from https://github.com/odo-devfiles/nodejs-ex.git [1s]

Please use `odo push` command to create the component with source deployed

It works fine.

Actual behavior

Expected behavior

When we use --context flag, I thing cd should not require for creating the component.

Any logs, error output, etc?

Trying steps manually

[valaparthvi]

It seems to be working fine for me -

➜  empty_dir mkdir smh1  
➜  empty_dir odo create nodejs --starter --context ./smh1/   
Devfile Object Validation
 ✓  Checking devfile existence [76637ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [78892ns]
Validation
 ✓  Validating if devfile name is correct [138053ns]

Starter Project
 ✓  Downloading starter project nodejs-starter from https://github.com/odo-devfiles/nodejs-ex.git [863ms]

Please use `odo push` command to create the component with source deployed

odo version - odo v2.0.7 (f0d881d)
OS: Fedora 32

[kadel]

working for me as well (using 6a73597)
/close

@prietyc123 If this is still an issue for you feel free to reopen.
To help with the reproduction and investigation please try to paste the actual odo version output or specify what git revision you were using. Saying just master makes it impossible to find what you were running.

[openshift-ci-robot]

@kadel: Closing this issue.

In response to this:

working for me as well (using 6a73597)
/close

@prietyc123 If this is still an issue for you feel free to reopen.
To help with the reproduction and investigation please try to paste the actual odo version output or specify what git revision you were using. Saying just master makes it impossible to find what you were running.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.