Modifies newKubernetesAdapter() and others #4563

mik-dass · 2021-03-29T14:00:27Z

What type of PR is this?

/kind failing-test

What does does this PR do / why we need it:

It initializes the kubernetes adapter with a occlient instead of a kubeclient.

Which issue(s) this PR fixes:

Fixes #4562

PR acceptance criteria:

Unit test
Integration test
Documentation
I have read the test guidelines

How to test changes / Special notes to the reviewer:

Running the tests with an invalid KUBECONFIG for the project should pass.

export KUBECONFIG=/tmp/test/asfdasdf
make test

openshift-ci-robot · 2021-03-29T14:00:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mik-dass]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dharmit · 2021-03-30T05:40:20Z

/lgtm

openshift-bot · 2021-03-30T05:45:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T05:58:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T06:11:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T06:24:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T06:37:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T06:50:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T07:03:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T07:16:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mohammedzee1000 · 2021-03-30T07:18:39Z

Tests appear to be failing on conversion should convert s2i component to devfile component successfully

prietyc123 · 2021-03-30T07:20:45Z

convert-to-devfile panics out

[odo] I0329 15:29:07.132666   30294 pods.go:76] Pod mynodejs-7966dbb4b6-v6knz is Running
[odo] 
 ✓  Waiting for component to start [92ms]
[odo] I0329 15:29:07.198170   30294 events.go:36] Quitting collect events
[odo] panic: runtime error: invalid memory address or nil pointer dereference
[odo] [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x18841f4]
[odo] 
[odo] goroutine 1 [running]:
[odo] github.com/openshift/odo/pkg/occlient.(*Client).GetKubeClient(...)
[odo] 	/go/src/github.com/openshift/odo/pkg/occlient/occlient.go:1225
[odo] github.com/openshift/odo/pkg/occlient.(*Client).IsRouteSupported(...)
[odo] 	/go/src/github.com/openshift/odo/pkg/occlient/routes.go:15
[odo] github.com/openshift/odo/pkg/component.ApplyConfig(0x0, 0xc000147950, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
[odo] 	/go/src/github.com/openshift/odo/pkg/component/component.go:624 +0x1d4
[odo] github.com/openshift/odo/pkg/devfile/adapters/kubernetes/component.Adapter.Push(0xc000147950, 0x2390fe0, 0xc0003aa1c0, 0x232cd20, 0xc0003aa240, 0x2353240, 0xc0003aa2c0, 0x2353280, 0xc0003aa370, 0x232cda0, ...)
[odo] 	/go/src/github.com/openshift/odo/pkg/devfile/adapters/kubernetes/component/adapter.go:203 +0x9a5
[odo] github.com/openshift/odo/pkg/devfile/adapters/kubernetes.Adapter.Push(0x23a21e0, 0xc0005fc410, 0x7ffc107bbc93, 0xe, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
[odo] 	/go/src/github.com/openshift/odo/pkg/devfile/adapters/kubernetes/adapter.go:37 +0x79
[odo] github.com/openshift/odo/pkg/odo/cli/component.(*PushOptions).devfilePushInner(0xc0003d8800, 0xc0000b20f0, 0x0)
[odo] 	/go/src/github.com/openshift/odo/pkg/odo/cli/component/devfile.go:145 +0x4e5
[odo] github.com/openshift/odo/pkg/odo/cli/component.(*PushOptions).DevfilePush(0xc0003d8800, 0x1b, 0xc0006c3d01)
[odo] 	/go/src/github.com/openshift/odo/pkg/odo/cli/component/devfile.go:56 +0x2f
[odo] github.com/openshift/odo/pkg/odo/cli/component.(*PushOptions).Run(0xc0003d8800, 0x0, 0x0)
[odo] 	/go/src/github.com/openshift/odo/pkg/odo/cli/component/push.go:265 +0x51
[odo] github.com/openshift/odo/pkg/odo/genericclioptions.GenericRun(0x2353700, 0xc0003d8800, 0xc000962c80, 0xc0001c5380, 0x0, 0x2)
[odo] 	/go/src/github.com/openshift/odo/pkg/odo/genericclioptions/runnable.go:78 +0x1da
[odo] github.com/openshift/odo/pkg/odo/cli/component.NewCmdPush.func1(0xc000962c80, 0xc0001c5380, 0x0, 0x2)
[odo] 	/go/src/github.com/openshift/odo/pkg/odo/cli/component/push.go:290 +0x5e
[odo] github.com/spf13/cobra.(*Command).execute(0xc000962c80, 0xc0001c5320, 0x2, 0x2, 0xc000962c80, 0xc0001c5320)
[odo] 	/go/src/github.com/openshift/odo/vendor/github.com/spf13/cobra/command.go:830 +0x2aa
[odo] github.com/spf13/cobra.(*Command).ExecuteC(0xc0001ca500, 0x20e44b8, 0xc000059b60, 0x3)
[odo] 	/go/src/github.com/openshift/odo/vendor/github.com/spf13/cobra/command.go:914 +0x2fb
[odo] github.com/spf13/cobra.(*Command).Execute(...)
[odo] 	/go/src/github.com/openshift/odo/vendor/github.com/spf13/cobra/command.go:864
[odo] main.main()
[odo] 	/go/src/github.com/openshift/odo/cmd/odo/odo.go:68 +0x330

prietyc123 · 2021-03-30T07:21:20Z

/hold

prietyc123 · 2021-03-30T08:18:43Z

Secret issue with operatorhub

✗  Waiting for component to start [5m] [WARNING x7: Failed]
[odo]  ✗  Failed to start component with name wxloqr. Error: Failed to create the component: error while waiting for deployment rollout: timeout while waiting for wxloqr deployment roll out\nFor more information to help determine the cause of the error, re-run with '-v'.
[odo] See below for a list of failed events that occured more than 5 times during deployment:
[odo] 
[odo]  NAME                                      COUNT  REASON  MESSAGE                        
[odo] 
[odo]  wxloqr-7d75cb68b5-mx62w.16710e798d36479f  7      Failed  Error: secret                  
[odo]                                                           "wxloqr-etcdcluster-example"   
[odo]                                                           not found                      
[odo] 
[odo]

I think #4554 will fix the secret issue.

/test v4.7-integration-e2e

dharmit · 2021-03-30T11:10:29Z

/hold cancel

openshift-bot · 2021-03-30T11:49:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T12:02:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-03-30T13:59:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mik-dass · 2021-03-31T01:24:39Z

Checking if "imagestreams" resource supported
[odo] I0330 18:55:13.516732   28620 imageStreams.go:98] Found exact image tag match for java:8
[odo]  ✗  unable to find tag 8 for image java
Deleting dir: /tmp/043054859

/retest

dharmit · 2021-03-31T07:43:48Z

Seeing 15 occurrences of the telemetry question: Help odo improve by allowing it to collect usage data. Read about our privacy statement: https://developers.redhat.com/article/tool-data-collection. You can change your preference later by changing the ConsentTelemetry preference.

Quickest way to get rid of these is to use CommonBeforeEach function.

dharmit · 2021-03-31T07:50:23Z

Checking if "imagestreams" resource supported
[odo] I0330 18:55:13.516732   28620 imageStreams.go:98] Found exact image tag match for java:8
[odo]  ✗  unable to find tag 8 for image java
Deleting dir: /tmp/043054859

/retest

Even in retest I'm seeing numerous occurrences of the same message. Are you sure it's a flake and not a real problem?

prietyc123 · 2021-03-31T07:53:36Z

Even in retest I'm seeing numerous occurrences of the same message. Are you sure it's a flake and not a real problem?

I think this is an actual problem we are facing on CI currently. Even periodic jobs complains about the same. Let me have a look.

prietyc123 · 2021-03-31T09:49:04Z

PR #4569 will fix the issue.

kadel · 2021-03-31T13:25:56Z

/retest

dharmit · 2021-04-01T06:10:09Z

@mik-dass is this still supposed to be on hold?

mik-dass · 2021-04-01T06:24:42Z

@mik-dass is this still supposed to be on hold?

No the 4.7 test passed

kadel · 2021-04-01T06:38:56Z

/lgtm

openshift-bot · 2021-04-01T06:43:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-01T06:56:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-01T07:09:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-01T07:35:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-01T08:40:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dharmit · 2021-04-01T08:42:14Z

/override ci/prow/psi-minishift-integration-e2e
/override ci/prow/psi-minishift-integration-e2e
/override ci/prow/psi-openshift-integration-e2e

openshift-ci-robot · 2021-04-01T08:42:25Z

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/psi-minishift-integration-e2e, ci/prow/psi-openshift-integration-e2e

In response to this:

/override ci/prow/psi-minishift-integration-e2e
/override ci/prow/psi-minishift-integration-e2e
/override ci/prow/psi-openshift-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dharmit · 2021-04-01T08:42:52Z

/override ci/prow/psi-kubernetes-integration-e2e

openshift-ci-robot · 2021-04-01T08:43:01Z

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/psi-kubernetes-integration-e2e

In response to this:

/override ci/prow/psi-kubernetes-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-01T09:07:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dharmit · 2021-04-01T09:28:23Z

/override ci/prow/psi-openshift-integration-e2e

openshift-ci-robot · 2021-04-01T09:28:28Z

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/psi-openshift-integration-e2e

In response to this:

/override ci/prow/psi-openshift-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-01T10:12:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

kadel · 2021-04-01T11:01:26Z

/override ci/prow/psi-openshift-integration-e2e

openshift-ci-robot · 2021-04-01T11:01:33Z

@kadel: Overrode contexts on behalf of kadel: ci/prow/psi-openshift-integration-e2e

In response to this:

/override ci/prow/psi-openshift-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…es adapter with a occlient instead of a kubeclient (redhat-developer#4563)

openshift-ci-robot added the kind/failing-test label Mar 29, 2021

openshift-ci-robot requested review from mohammedzee1000 and valaparthvi March 29, 2021 14:00

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 29, 2021

dharmit approved these changes Mar 30, 2021

View reviewed changes

openshift-ci-robot assigned dharmit Mar 30, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 30, 2021

mik-dass force-pushed the fix_unit_test branch from 0249532 to 49766f0 Compare March 30, 2021 05:38

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 30, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 30, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Mar 30, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Mar 30, 2021

mik-dass removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 1, 2021

openshift-ci-robot assigned kadel Apr 1, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 1, 2021

openshift-merge-robot merged commit 81104cf into redhat-developer:master Apr 1, 2021

mik-dass deleted the fix_unit_test branch April 1, 2021 12:34

kadel pushed a commit to kadel/odo that referenced this pull request Apr 1, 2021

Modifies newKubernetesAdapter() and others to initialize the kubernet…

104117e

…es adapter with a occlient instead of a kubeclient (redhat-developer#4563)

Modifies newKubernetesAdapter() and others #4563

Modifies newKubernetesAdapter() and others #4563

Uh oh!

Conversation

mik-dass commented Mar 29, 2021

Uh oh!

openshift-ci-robot commented Mar 29, 2021

Uh oh!

dharmit commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

mohammedzee1000 commented Mar 30, 2021

Uh oh!

prietyc123 commented Mar 30, 2021

Uh oh!

prietyc123 commented Mar 30, 2021

Uh oh!

prietyc123 commented Mar 30, 2021

Uh oh!

dharmit commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

openshift-bot commented Mar 30, 2021

Uh oh!

mik-dass commented Mar 31, 2021

Uh oh!

dharmit commented Mar 31, 2021

Uh oh!

dharmit commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prietyc123 commented Mar 31, 2021

Uh oh!

prietyc123 commented Mar 31, 2021

Uh oh!

kadel commented Mar 31, 2021

Uh oh!

dharmit commented Apr 1, 2021

Uh oh!

mik-dass commented Apr 1, 2021

Uh oh!

kadel commented Apr 1, 2021

Uh oh!

openshift-bot commented Apr 1, 2021

Uh oh!

openshift-bot commented Apr 1, 2021

Uh oh!

openshift-bot commented Apr 1, 2021

Uh oh!

openshift-bot commented Apr 1, 2021

Uh oh!

openshift-bot commented Apr 1, 2021

Uh oh!

dharmit commented Apr 1, 2021

Uh oh!

openshift-ci-robot commented Apr 1, 2021

Uh oh!

dharmit commented Apr 1, 2021

Uh oh!

openshift-ci-robot commented Apr 1, 2021

Uh oh!

openshift-bot commented Apr 1, 2021

dharmit commented Mar 31, 2021 •

edited

Loading