Skip to content

Fixes kClient namespace in createKubernetesAdapter() #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mik-dass
Copy link
Contributor

@mik-dass mik-dass commented Apr 12, 2021

What type of PR is this?

/kind bug

What does this PR do / why we need it:

It fixes kClient namespace in createKubernetesAdapter()

Which issue(s) this PR fixes:

Fixes #4609

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@mik-dass mik-dass added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 12, 2021
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 12, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 12, 2021
@mik-dass mik-dass requested a review from prietyc123 April 12, 2021 11:13
@prietyc123
Copy link
Contributor

I tested on minikube. Also on PSI, changes works fine.

$ odo push --context testpsi/

Validation
 ✓  Validating the devfile [181650ns]

Creating Kubernetes resources for component abcdef
 ✓  Waiting for component to start [32s]
 ✓  Waiting for component to start [7ms]
 ⚠  Unable to create ingress, missing host information for Endpoint 3000-tcp, please check instructions on URL creation (refer `odo url create --help`)


Applying URL changes
 ✓  URLs are synced with the cluster, no changes are required.

Syncing to component abcdef
 ✓  Checking files for pushing [306589ns]
 ✓  Syncing files to the component [108ms]

Executing devfile commands for component abcdef
 ✓  Waiting for component to start [2ms]
 ✓  Executing devbuild command "npm install" [3s]
 ✓  Executing devrun command "npm start" [1s]

Pushing devfile component abcdef
 ✓  Changes successfully pushed to component

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 12, 2021
@prietyc123 prietyc123 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 12, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@kadel
Copy link
Member

kadel commented Apr 12, 2021

/override ci/prow/psi-kubernetes-integration-e2e
/override ci/prow/psi-minishift-integration-e2e
/override ci/prow/psi-openshift-integration-e2e

@openshift-ci-robot
Copy link
Collaborator

@kadel: Overrode contexts on behalf of kadel: ci/prow/psi-kubernetes-integration-e2e, ci/prow/psi-minishift-integration-e2e, ci/prow/psi-openshift-integration-e2e

In response to this:

/override ci/prow/psi-kubernetes-integration-e2e
/override ci/prow/psi-minishift-integration-e2e
/override ci/prow/psi-openshift-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6040118 into redhat-developer:master Apr 13, 2021
@mik-dass mik-dass deleted the fix_kclient_namespace branch April 13, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odo push fails on "namespace mismatch" for the component created with default project
6 participants