-
Notifications
You must be signed in to change notification settings - Fork 243
Revert java import changes for s390x #4630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert java import changes for s390x #4630
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prietyc123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ping @xkwangcn could you please validate this pr change on s390x arch. |
/test psi-kubernetes-integration-e2e |
1 similar comment
/test psi-kubernetes-integration-e2e |
@xkwangcn did you have a chance to validate the changes in a s390x system? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
however holding until validation on a s390x system is confirmed
/hold
Hello, @prietyc123 @rnapoles-rh, I took vacation last week, sorry for slow reply. |
this is correct on s390x. please revert it. Thank you. |
/hold cancel |
@prietyc123 hi, I mean this change is correct, please merge this PR. |
What type of PR is this?
/kind failing-test
What does this PR do / why we need it:
Reverting back changes in #4602 as
registry.redhat.io/redhat-openjdk-18/openjdk18-openshift:latest
has been fixed.Which issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
It should run successfully on s390x arch.