Skip to content

Revert java import changes for s390x #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:
Reverting back changes in #4602 as registry.redhat.io/redhat-openjdk-18/openjdk18-openshift:latest has been fixed.

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
It should run successfully on s390x arch.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prietyc123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 16, 2021
@prietyc123
Copy link
Contributor Author

ping @xkwangcn could you please validate this pr change on s390x arch.

@prietyc123
Copy link
Contributor Author

/test psi-kubernetes-integration-e2e

1 similar comment
@prietyc123
Copy link
Contributor Author

/test psi-kubernetes-integration-e2e

@rnapoles-rh
Copy link
Contributor

@xkwangcn did you have a chance to validate the changes in a s390x system?

Copy link
Contributor

@rnapoles-rh rnapoles-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
however holding until validation on a s390x system is confirmed
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 19, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 19, 2021
@xkwangcn
Copy link
Contributor

Hello, @prietyc123 @rnapoles-rh, I took vacation last week, sorry for slow reply.
I will verify it today, Thank you.

@xkwangcn
Copy link
Contributor

this is correct on s390x. please revert it. Thank you.

@prietyc123
Copy link
Contributor Author

this is correct on s390x. please revert it. Thank you.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Apr 20, 2021
@xkwangcn
Copy link
Contributor

@prietyc123 hi, I mean this change is correct, please merge this PR.

@openshift-merge-robot openshift-merge-robot merged commit 521a346 into redhat-developer:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants