-
Notifications
You must be signed in to change notification settings - Fork 243
Update devfile tests with OCI-based registry #4679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devfile tests with OCI-based registry #4679
Conversation
/assign @GeekArthur |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josephca The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rnapoles-rh Here is the detail :
|
* 'main' of github.com:openshift/odo: Make Telemetry upload faster (#4565)
@GeekArthur - please review. Thanks, |
So odo tests would fail if there is breaking changing in the staging registry? wouldn't that block us? |
Even I do feel the same. @josephca Currently the breaking changes in devfile registry are bothering us more and now it seems like we need to deal with staging one as well, no? |
@girishramnani @prietyc123 Thanks for your inputs. That said, I will update the code to use the staging server only. |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @rnapoles-rh |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani, josephca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What does this PR do / why we need it:
After moving to use OCI-based registry (#4525), devfile tests should be using OCI-based registry as well.
Which issue(s) this PR fixes:
Related issues:
devfile/api#367
#4504
#4525
PR acceptance criteria:
Unit test
Integration test
Documentation
I have read the test guidelines
How to test changes / Special notes to the reviewer:
This PR is for changing test codes.