Add telemetry contextual properties if it is enabled #4870

valaparthvi · 2021-07-02T05:15:44Z

What type of PR is this?
/kind cleanup

What does this PR do / why we need it:
The changes introduced with this PR will add properties to telemetry context only if telemetry is enabled.

Which issue(s) this PR fixes:

Fixes part of #4462

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
There isn't much to test here, except you can disable telemetry and check if the data is added to contextual property with debugger.

valaparthvi · 2021-07-02T07:04:03Z

/test v4.7-integration-e2e

Looks like a flaky test -

[odo] I0702 06:42:31.202940   66152 kclient.go:215] Checking if "ingresses" resource supported
[odo] I0702 06:42:31.372793   66152 kclient.go:215] Checking if "projects" resource supported
[odo] I0702 06:42:31.544924   66152 kclient.go:215] Checking if "projects" resource supported
[odo]  ⚠  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo] I0702 06:42:31.647162   66152 segment.go:210] Checking telemetry enable status
[odo] I0702 06:42:31.647171   66152 segment.go:223] Sending telemetry disabled by ODO_DISABLE_TELEMETRY=true
[odo] I0702 06:42:31.647180   66152 odo.go:75] Could not get the latest release information in time. Never mind, exiting gracefully :)
[odo]  ✓  Deleted project : e2e-images-test102oqy
Setting current dir to: /go/src/github.com/openshift/odo/tests/e2escenarios
Deleting dir: /tmp/452846782

�[32m•�[0m�[32m•�[0m�[32m•�[0m�[32m•�[0m�[32m•�[0m�[32m•�[0m�[32m•�[0m�[32m•�[0m�[32m•�[0m�[32m•�[0m�[32m•�[0m�[32m•�[0m

�[91m�[1mSummarizing 1 Failure:�[0m

�[91m�[1m[Fail] �[0m�[90modo supported images e2e tests �[0m�[0modo supported images deployment on amd64 �[0m�[91m�[1m[It] Should be able to verify the nodejs-12-centos7 image �[0m
�[37m/go/src/github.com/openshift/odo/tests/helper/helper_generic.go:82�[0m

�[1m�[91mRan 21 of 21 Specs in 408.084 seconds�[0m
�[1m�[91mFAIL!�[0m -- �[32m�[1m20 Passed�[0m | �[91m�[1m1 Failed�[0m | �[33m�[1m0 Pending�[0m | �[36m�[1m0 Skipped�[0m


Ginkgo ran 1 suite in 6m51.562366135s
Test Suite Failed
exit status 1
make: *** [test-e2e-all] Error 1
+ error=true
+ '[' true ']'
+ exit -1
{"component":"entrypoint","error":"wrapped process failed: exit status 255","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-07-02T06:47:21Z"}
error: failed to execute wrapped command: exit status 255

feloy · 2021-07-02T12:59:44Z

/lgtm

dharmit · 2021-07-02T13:31:29Z

pkg/odo/cli/component/push.go

@@ -258,16 +260,22 @@ func (po *PushOptions) Validate() (err error) {

 // Run has the logic to perform the required actions as part of command
 func (po *PushOptions) Run(cmd *cobra.Command) (err error) {
-	scontext.SetClusterType(cmd.Context(), po.Client)
+	if segment.IsTelemetryEnabled(nil) {


There are multiple calls to segment.IsTelemetryEnabled(nil) in this function. Can we store the return value of segment.IsTelemetryEnabled(nil) into some variable so that it can be reused?

I was thinking the same, perhaps adding a property to cobra command or something that is common across all the commands. Let me take a look.

There, done. Amended the multiple calls to IsTelemetryEnabled by adding its value to cmd.Context.

valaparthvi · 2021-07-04T11:39:08Z

/retest

valaparthvi · 2021-07-05T04:51:57Z

/retest

sonarqubecloud · 2021-07-05T07:16:15Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

No Coverage information
6.7% Duplication

feloy · 2021-07-05T09:09:15Z

/approve

openshift-ci · 2021-07-05T09:09:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [feloy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-07-05T09:14:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T09:26:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T09:38:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T09:50:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T10:50:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T11:02:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T11:38:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T11:50:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

valaparthvi · 2021-07-05T11:58:41Z

/test all

valaparthvi · 2021-07-05T12:00:56Z

/retest

openshift-bot · 2021-07-05T12:02:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

prietyc123 · 2021-07-05T12:08:44Z

/test all

prietyc123 · 2021-07-05T12:08:59Z

/refresh

prietyc123 · 2021-07-05T12:18:53Z

New changes are detected. LGTM label has been removed.

Just a force push to remove non existence job

/lgtm

openshift-bot · 2021-07-05T12:50:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T13:14:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T13:38:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-07-05T13:50:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-07-05T20:50:34Z

@valaparthvi: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/psi-kubernetes-integration-e2e	`45f98d8`	link	`/test psi-kubernetes-integration-e2e`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dharmit · 2021-07-06T06:02:04Z

/override ci/prow/psi-unit-test-mac
/override ci/prow/psi-unit-test-windows

Overriding tests since team's debugging issue with Jenkins.

/lgtm

openshift-ci · 2021-07-06T06:02:07Z

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/psi-unit-test-mac, ci/prow/psi-unit-test-windows

In response to this:

/override ci/prow/psi-unit-test-mac
/override ci/prow/psi-unit-test-windows

Overriding tests since team's debugging issue with Jenkins.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-07-06T06:03:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

…r#4870) * Add telemetry contextual properties if it is enabled * update changelog * Remove the redundant calls to IsTelemetryEnabled

openshift-ci bot added the kind/cleanup label Jul 2, 2021

openshift-ci bot requested review from mik-dass and rnapoles-rh July 2, 2021 05:15

valaparthvi mentioned this pull request Jul 2, 2021

Track telemetry implementation for odo #4462

Closed

17 tasks

openshift-ci bot assigned feloy Jul 2, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 2, 2021

dharmit suggested changes Jul 2, 2021

View reviewed changes

openshift-ci bot assigned dharmit Jul 2, 2021

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 2, 2021

valaparthvi force-pushed the checktstatus branch from 930a1ea to f4cc5ef Compare July 3, 2021 18:22

valaparthvi force-pushed the checktstatus branch from f4cc5ef to 88e7be0 Compare July 5, 2021 07:14

dharmit approved these changes Jul 5, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 5, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 5, 2021

redhat-developer deleted a comment from openshift-ci bot Jul 5, 2021

valaparthvi added 3 commits July 5, 2021 17:45

Add telemetry contextual properties if it is enabled

7654507

update changelog

b85ce3d

Remove the redundant calls to IsTelemetryEnabled

1d01cde

valaparthvi force-pushed the checktstatus branch from 88e7be0 to 1d01cde Compare July 5, 2021 12:15

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 5, 2021

openshift-ci bot assigned prietyc123 Jul 5, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 5, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 5, 2021

Merge branch 'main' into checktstatus

45f98d8

openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. Required by Prow. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels Jul 5, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 6, 2021

openshift-merge-robot merged commit 7c8398f into redhat-developer:main Jul 6, 2021

rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023

Add telemetry contextual properties if it is enabled #4870

Add telemetry contextual properties if it is enabled #4870

Uh oh!

Conversation

valaparthvi commented Jul 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

valaparthvi commented Jul 2, 2021

Uh oh!

feloy commented Jul 2, 2021

Uh oh!

dharmit Jul 2, 2021

Choose a reason for hiding this comment

Uh oh!

valaparthvi Jul 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

valaparthvi Jul 3, 2021

Choose a reason for hiding this comment

Uh oh!

valaparthvi commented Jul 4, 2021

Uh oh!

valaparthvi commented Jul 5, 2021

Uh oh!

sonarqubecloud bot commented Jul 5, 2021

Uh oh!

feloy commented Jul 5, 2021

Uh oh!

openshift-ci bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

valaparthvi commented Jul 5, 2021

Uh oh!

valaparthvi commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

prietyc123 commented Jul 5, 2021

Uh oh!

prietyc123 commented Jul 5, 2021

Uh oh!

prietyc123 commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-bot commented Jul 5, 2021

Uh oh!

openshift-ci bot commented Jul 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dharmit commented Jul 6, 2021

Uh oh!

openshift-ci bot commented Jul 6, 2021

Uh oh!

openshift-bot commented Jul 6, 2021

Uh oh!

Uh oh!

valaparthvi commented Jul 2, 2021 •

edited

Loading

valaparthvi Jul 2, 2021 •

edited

Loading

openshift-ci bot commented Jul 5, 2021 •

edited

Loading