Fix reports directory for operatorhub nightly tests #4972
Conversation
|
I have also fixed it for periodic and regular prow tests report generation via commit a797ef2 |
prietyc123
force-pushed
the
FixReportsDirForNightly
branch
from
5f2793d to
5510ed0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
ocp 4.8 ci failing due to #4960 /test v4.8-integration-e2e |
|
@prietyc123: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -40,6 +40,6 @@ if [ $error ]; then | |||
| exit -1 | |||
| fi | |||
|
|
|||
| cp -r reports $ARTIFACT_DIR | |||
| cp -r reports tests/reports $ARTIFACT_DIR | |||
There was a problem hiding this comment.
This will copy both reports and tests/reports into $ARTIFACT_DIR and merge the contents of two directories. Is that what we want?
# a, b and c are directories; c is empty so far.
$ tree a b c
a
└── hello
b
└── a
└── hi
c
1 directory, 2 files
$ cp -r a b/a c
$ tree c
c
└── a
├── hello
└── hiThere was a problem hiding this comment.
Ack, thanks. Only wanted to confirm it.
openshift-ci
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dharmit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
What type of PR is this?
/kind failing-test
What does this PR do / why we need it:
This PR will fix nightly test build failure for reports path https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-odo-main-v4.8-operatorhub-integration-nightly/1423433739802775552#1:build-log.txt%3A535
As we only run operator hub tests on nightly. It generates reports under
testsdirectory and we are searching into currentododirectory currently. Hence it error out withno such file or directoryWhich issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:
Unit test
Integration test
Documentation
Update changelog
I have read the test guidelines
How to test changes / Special notes to the reviewer:
Nightly test should not fail.