update health check required versions for 3.9 #6757
Conversation
openshift-ci-robot
added
the
size/L
| """Parse and return the deployed version of OpenShift as a tuple.""" | ||
| if openshift_image_tag and openshift_image_tag[0] == 'v': | ||
| openshift_image_tag = openshift_image_tag[1:] |
There was a problem hiding this comment.
Did some previous change obviate need to strip any leading 'v'?
There was a problem hiding this comment.
Parsing with a regex instead of splitting on .
| latest = max(version_map) | ||
| if openshift_version < earliest: | ||
| return version_map[earliest] | ||
| if openshift_version > latest: |
There was a problem hiding this comment.
You could change < and > to <= and >=, respectively, but this is fine as is.
|
@sosiouxme: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
enough with the flakes. |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1534922
A little refactoring in the first commits to reuse code and prevent having to update this for every single release. Then, updating the actual versions for 3.9.