Skip to content

Docs: Updates to Egress router DNS proxy mode #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2018
Merged

Docs: Updates to Egress router DNS proxy mode #4910

merged 1 commit into from
May 9, 2018

Conversation

pravisankar
Copy link

Updated based on feedback on openshift/origin#15409 and #4854

@pravisankar
Copy link
Author

@danwinship @bfallonf PTAL

@bfallonf
Copy link

bfallonf commented Aug 2, 2017

Thanks @pravisankar . @danwinship , any thoughts or should I go ahead and merge?

@bfallonf bfallonf added this to the Future Release milestone Aug 2, 2017
@bfallonf
Copy link

bfallonf commented Sep 6, 2017

Updated to 3.8 as per conversation in #4854

@ncbaratta ncbaratta added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 9, 2017
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2018
@vikram-redhat
Copy link
Contributor

@bfallonf I have changed the labels and assigned to you. Will also require QE approval.

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 3, 2018
@pravisankar pravisankar force-pushed the egress-dns-proxy branch 2 times, most recently from 8d4b06c to d15e6a7 Compare May 3, 2018 19:16
@pravisankar
Copy link
Author

@openshift/team-documentation @bfallonf @knobunc @danwinship updated, PTAL

knobunc
knobunc approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want the "why" part, but otherwise it's good.

admin_guide/managing_networking.adoc Outdated
In _DNS proxy mode_, the egress router runs as a DNS proxy for TCP based services from
its own IP address to one or more destination IP addresses. Client pods that want to
make use of the reserved source IP address must be modified to connect to the egress
router rather than connecting directly to the destination IP.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to say why, but otherwise looks great.

@pravisankar
Copy link
Author

@bfallonf @knobunc updated, PTAL

@bfallonf
Copy link

bfallonf commented May 9, 2018

Thanks @pravisankar . This is great. I'll merge this and cherrypick to 3.10 (as per info in https://trello.com/c/407uoUFz/495-5-allow-dns-names-for-egress-routers-human-names-egressdemo ) and do a quick followup for some standards fixes.

@bfallonf bfallonf merged commit a9bdc6c into openshift:master May 9, 2018
@bfallonf
Copy link

bfallonf commented May 9, 2018

/cherrypick enterprise-3.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 9, 2018
Merged
@openshift-cherrypick-robot
Copy link

@bfallonf: new pull request created: #9111

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfallonf bfallonf mentioned this pull request May 9, 2018
Merged
@vikram-redhat vikram-redhat removed this from the Future Release milestone Jul 31, 2018
@vikram-redhat vikram-redhat added this to the OCP 3.10 GA milestone Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

Assignees

@bfallonf bfallonf

Labels
branch/enterprise-3.10 peer-review-needed Signifies that the peer review team needs to review this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 3.10 GA
Development

Successfully merging this pull request may close these issues.
8 participants
@pravisankar @bfallonf @vikram-redhat @openshift-cherrypick-robot @knobunc @ncbaratta @openshift-bot @openshift-ci-robot