Skip to content

Remove CapabilitiesAll from main api types #15273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deads2k opened this issue Jul 18, 2017 · 1 comment · Fixed by #15135
Closed

Remove CapabilitiesAll from main api types #15273

deads2k opened this issue Jul 18, 2017 · 1 comment · Fixed by #15135
Assignees
@php-coder
Labels
kind/post-rebase priority/P1
Milestone
v3.7

Comments

@deads2k
Copy link
Contributor

deads2k commented Jul 18, 2017

@php-coder I think you have a pull for this already. Please link it here and we'll merge it post-rebase to clear the carry.
@deads2k deads2k added this to the 3.7.0 milestone Jul 18, 2017
@deads2k deads2k mentioned this issue Jul 18, 2017
Closed
56 tasks
@php-coder
Copy link
Contributor

Here is the PR: #15135

@php-coder php-coder mentioned this issue Jul 20, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Jul 28, 2017
@openshift-merge-robot
Merge pull request #15135 from php-coder/capabilities_all_refactoring
4c1e092 
Automatic merge from submit-queue

Move CapabilityAll from k8s types and rename it to AllowAllCapabilities

Move `CapabilityAll` from k8s types to openshift, close to the SCC definition and also rename it to `AllowAllCapabilities`.

Addresses #12875 (comment) and fixes #15273

PTAL @deads2k @pweil- 
CC @simo5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
kind/post-rebase priority/P1
Projects
None yet
Milestone
v3.7
Development

Successfully merging a pull request may close this issue.

Move CapabilityAll from k8s types and rename it to AllowAllCapabilities php-coder/origin
2 participants
@php-coder @deads2k