Skip to content

[Feature:DeploymentConfig] deploymentconfigs won't deploy RC with unresolved images [Conformance] when patched with empty image #18982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simo5 opened this issue Mar 14, 2018 · 10 comments
Closed

[Feature:DeploymentConfig] deploymentconfigs won't deploy RC with unresolved images [Conformance] when patched with empty image #18982

simo5 opened this issue Mar 14, 2018 · 10 comments
Assignees
@mfojtik @deads2k
Labels
kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1 sig/master

Comments

@simo5
Copy link
Contributor

simo5 commented Mar 14, 2018

Sound slike a flake:

/tmp/openshift/build-rpms/rpm/BUILD/origin-3.10.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:134
Expected error:
    <*errors.StatusError | 0xc420d413b0>: {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {SelfLink: "", ResourceVersion: "", Continue: ""},
            Status: "Failure",
            Message: "Internal error occurred: rolebindings.rbac.authorization.k8s.io \"system:image-pullers\" already exists",
            Reason: "InternalError",
            Details: {
                Name: "",
                Group: "",
                Kind: "",
                UID: "",
                Causes: [
                    {
                        Type: "",
                        Message: "rolebindings.rbac.authorization.k8s.io \"system:image-pullers\" already exists",
                        Field: "",
                    },
                ],
                RetryAfterSeconds: 0,
            },
            Code: 500,
        },
    }
    Internal error occurred: rolebindings.rbac.authorization.k8s.io "system:image-pullers" already exists
not to have occurred
/tmp/openshift/build-rpms/rpm/BUILD/origin-3.10.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:190```
@simo5 simo5 added the kind/test-flake Categorizes issue or PR as related to test flakes. label Mar 14, 2018
@simo5 simo5 mentioned this issue Mar 14, 2018
Merged
@stevekuznetsov
Copy link
Contributor

/cc @bparees

@bparees
Copy link
Contributor

bparees commented Mar 14, 2018

@simo5 please link the job when reporting flakes.

@stevekuznetsov this is either a bad deploymentconfig test case that is creating bad bindings, or something fundamental in cluster setup creating bad bindings. Either way it's master team.

@simo5
Copy link
Contributor Author

simo5 commented Mar 14, 2018

Another one that failed the same way, also in deploymentconfigs, but not exactly the same test:
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18868/test_pull_request_origin_extended_conformance_install/9084/

@bparees
Copy link
Contributor

bparees commented Mar 14, 2018 

Mar 14 20:29:31.406: INFO: The user is now "extended-test-cli-deployment-wp4xn-p72rp-user"
Mar 14 20:29:31.406: INFO: Creating project "extended-test-cli-deployment-wp4xn-p72rp"
Mar 14 20:29:31.526: INFO: Failed to create a project and namespace "extended-test-cli-deployment-wp4xn-p72rp": Internal error occurred: rolebindings.rbac.authorization.k8s.io "system:image-pullers" already exists

@bparees
Copy link
Contributor

bparees commented Mar 14, 2018

seems like an issue w/ the SA creation/permission bindings being performed multiple times?

or a race condition in the creation logic?

@simo5
Copy link
Contributor Author

simo5 commented Mar 14, 2018

My fear is that it may be a side effect of this recent PR:
#18795

@deads2k what doyou think ?

@bparees
Copy link
Contributor

bparees commented Mar 14, 2018

The title certainly makes it look suspicious.

@deads2k deads2k mentioned this issue Mar 15, 2018
Closed
@enj enj mentioned this issue Mar 15, 2018
Merged
@stevekuznetsov
Copy link
Contributor

/assign @deads2k

openshift-merge-robot added a commit that referenced this issue Mar 16, 2018
@openshift-merge-robot
Merge pull request #18995 from enj/enj/i/role_binding_race/18982
8f99915 
Automatic merge from submit-queue.

Handle role binding AlreadyExists errors on project creation

This change correctly allows AlreadyExists errors for the default role bindings during project creation (which is race between the API master and the default role binding controller).  However, it does
not generically ignore these errors.

Signed-off-by: Monis Khan <[email protected]>

Fixes #18982
Alternative to #18994
/kind bug
/assign @simo5 @deads2k
@openshift/sig-master
@iftachsc
Copy link

iftachsc commented Apr 7, 2018 •
edited
Loading

seeing this in RedHat OCP 3.7 terrible. its on new-project instruction!
Internal error occurred: rolebindings.rbac.authorization.k8s.io "system:image-pullers" already exists, verb=new-project

@iftachsc
Copy link

iftachsc commented Apr 7, 2018

ok after sometime i understood why its happenning. it is still poor that it cannot be dealt since solution is so easy - but it is a kubernetes thing. not openshift :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfojtik mfojtik

@deads2k deads2k

Labels
kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1 sig/master
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ignore already exist errors in project template deads2k/origin
6 participants
@mfojtik @bparees @stevekuznetsov @deads2k @simo5 @iftachsc