Skip to content

openshift-merge-robot is not allowed to merge PRs #18987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0xmichalis opened this issue Mar 15, 2018 · 5 comments
Closed

openshift-merge-robot is not allowed to merge PRs #18987

0xmichalis opened this issue Mar 15, 2018 · 5 comments

Comments

@0xmichalis
Copy link
Contributor

I0315 00:50:50.565957       1 github.go:2074] Merging PR# 18973
I0315 00:50:50.565994       1 github.go:2299] Commenting in 18973: "Automatic merge from submit-queue."
E0315 00:50:51.157001       1 github.go:2141] Failed to merge PR: 18973: PUT https://api.github.com/repos/openshift/origin/pulls/18973/merge: 405 You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information. []
...
I0314 22:23:59.371825       1 github.go:2299] Commenting in 18977: "Automatic merge from submit-queue."
E0314 22:23:59.948110       1 github.go:2141] Failed to merge PR: 18977: PUT https://api.github.com/repos/openshift/origin/pulls/18977/merge: 405 You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information. []

/priority P0

@smarterclayton @stevekuznetsov @jupierce

@0xmichalis
Copy link
Contributor Author

/sig continuous-delivery

@smarterclayton
Copy link
Contributor

smarterclayton commented Mar 15, 2018 via email

@smarterclayton
Copy link
Contributor

smarterclayton commented Mar 15, 2018 via email

@jupierce
Copy link
Contributor

@nhr had requested this specifically to help control changes after devcut. The impact is expected and not ideal, but our only way of keeping Harrison in control of merges into these branches. We need to revisit how we do this for subsequent releases (merge gating labels per branch).

For now, merge permissions have been reverted back to nhr.

@0xmichalis
Copy link
Contributor Author

we don't have a bot driven central approval flow.

Do we need something more strict than OWNERS files?

merge gating labels per branch

Once we switch prow to do Origin merges (soon I hope), this will be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants