Skip to content

Build pod controller: Always set pod name annotation on build #10110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Jul 29, 2016

When cloning a build, the build pod name annotation is not getting updated on the cloned build because one from the cloned build exists.

@csrwng
Copy link
Contributor Author

csrwng commented Jul 29, 2016

@bparees This is an unexpected effect of my recent change to the build pod controller. There's no reason not to overwrite the annotation. Previously I was not setting it if it already exists, but found it's not the right thing to do when dealing with a build that has been cloned. ptal.

@bparees
Copy link
Contributor

bparees commented Jul 30, 2016

Lgtm [merge]

@bparees
Copy link
Contributor

bparees commented Jul 30, 2016

Flake #9959

[merge]

Ben Parees | OpenShift

On Jul 30, 2016 12:15 AM, "OpenShift Bot" [email protected] wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7196/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10110 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3kCTSCHtOqGaXC0DpURVHGy4zS_zks5qas_0gaJpZM4JYW34
.

@csrwng
Copy link
Contributor Author

csrwng commented Jul 30, 2016

flake #9959
[merge]

@csrwng
Copy link
Contributor Author

csrwng commented Jul 30, 2016

Flake #9959
[merge]

@bparees
Copy link
Contributor

bparees commented Jul 30, 2016

[merge]

Ben Parees | OpenShift

On Jul 30, 2016 3:20 PM, "OpenShift Bot" [email protected] wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7209/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10110 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3qoVxlaWMJpwL3IFAixWlKltFnP3ks5qa6P9gaJpZM4JYW34
.

@bparees
Copy link
Contributor

bparees commented Jul 30, 2016

https_://github.com/ http://github.com/__openshift__/origin/issues/9959_

[merge]

Ben Parees | OpenShift

On Jul 30, 2016 5:15 PM, "OpenShift Bot" [email protected] wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7211/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10110 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3gPlkMzm6A7d3VTuTs8TTek6skPuks5qa77vgaJpZM4JYW34
.

@csrwng
Copy link
Contributor Author

csrwng commented Jul 31, 2016

#9959
[merge]

@csrwng
Copy link
Contributor Author

csrwng commented Jul 31, 2016

#9775
[merge]

@csrwng
Copy link
Contributor Author

csrwng commented Jul 31, 2016

#9959
[merge]

@csrwng
Copy link
Contributor Author

csrwng commented Aug 1, 2016

#9775
[merge]

@bparees
Copy link
Contributor

bparees commented Aug 1, 2016

#9959

[merge]

On Sun, Jul 31, 2016 at 11:40 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7230/)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10110 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3sO6YbVx91q_Ju0XM2LHAP0Nj8rVks5qbWqugaJpZM4JYW34
.

Ben Parees | OpenShift

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 1, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7347/) (Image: devenv-rhel7_4719)

@bparees
Copy link
Contributor

bparees commented Aug 1, 2016

flake #9959
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 30bae45

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@csrwng
Copy link
Contributor Author

csrwng commented Aug 1, 2016

issue with jenkins job post-build script
[merge]

@stevekuznetsov
Copy link
Contributor

re[test]

@csrwng
Copy link
Contributor Author

csrwng commented Aug 1, 2016

#7355
[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 30bae45

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7334/)

@openshift-bot openshift-bot merged commit 14c1a78 into openshift:master Aug 2, 2016
@csrwng csrwng deleted the build_pod_annotation_fix branch December 21, 2016 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants