-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Build pod controller: Always set pod name annotation on build #10110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build pod controller: Always set pod name annotation on build #10110
Conversation
@bparees This is an unexpected effect of my recent change to the build pod controller. There's no reason not to overwrite the annotation. Previously I was not setting it if it already exists, but found it's not the right thing to do when dealing with a build that has been cloned. ptal. |
Lgtm [merge] |
Flake #9959 [merge] Ben Parees | OpenShift On Jul 30, 2016 12:15 AM, "OpenShift Bot" [email protected] wrote:
|
flake #9959 |
Flake #9959 |
[merge] Ben Parees | OpenShift On Jul 30, 2016 3:20 PM, "OpenShift Bot" [email protected] wrote:
|
https_://github.com/ http://github.com/__openshift__/origin/issues/9959_ [merge] Ben Parees | OpenShift On Jul 30, 2016 5:15 PM, "OpenShift Bot" [email protected] wrote:
|
#9959 |
#9775 |
#9959 |
#9775 |
[merge] On Sun, Jul 31, 2016 at 11:40 PM, OpenShift Bot [email protected]
Ben Parees | OpenShift |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7347/) (Image: devenv-rhel7_4719) |
flake #9959 |
Evaluated for origin merge up to 30bae45 |
[Test]ing while waiting on the merge queue |
issue with jenkins job post-build script |
re[test] |
#7355 |
Evaluated for origin test up to 30bae45 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7334/) |
When cloning a build, the build pod name annotation is not getting updated on the cloned build because one from the cloned build exists.