Make import image more efficient

[miminar]

Fetch manifest directly by tag without resolving it first.

This also works around satellite registry not setting Content-Type on GET /v2/<name>/manifests/<reference>.

[miminar]

[test]

/cc @soltysh, @legionus

[openshift-bot]

Evaluated for origin test up to f771f0c

[smarterclayton]

This is backwards compatible with old docker registries?

[miminar]

This is backwards compatible with old docker registries?

Docker daemon uses it https://github.com/docker/docker/blob/master/distribution/pull_v2.go#L340.

In the upstream API v2 spec, the support for manifest fetching using digest or tag appears to be from the very beginning: https://github.com/docker/distribution/blob/v2.0.0/docs/spec/api.md#pulling-an-image-manifest

[smarterclayton]

Ok, just wanted to be sure.

On Fri, Aug 5, 2016 at 12:32 PM, Michal Minář [email protected]
wrote:

This is backwards compatible with old docker registries?

Docker daemon uses it
https://github.com/docker/docker/blob/master/distribution/pull_v2.go#L340.

In the upstream API v2 spec, the support for manifest fetching using
digest or tag appears to be from the very beginning:
https://github.com/docker/distribution/blob/v2.0.0/docs/spec/api.md#pulling-an-image-manifest

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10244 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p31tsvMrfFMUA7wxeFw2hIJ3po9fks5qc2W0gaJpZM4Jd1US
.

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7569/)

[soltysh]

LGTM [merge]

[openshift-bot]

Evaluated for origin merge up to f771f0c

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7569/) (Image: devenv-rhel7_4789)