show namespace for custom strategy bc #10340
Conversation
|
[test] |
| os::cmd::expect_success 'oc create -f examples/sample-app/application-template-custombuild.json' | ||
| os::cmd::expect_failure_and_text 'oc new-app ruby-helloworld-sample' 'deploymentconfig "frontend" created' | ||
| os::cmd::expect_success_and_text 'oc get all --all-namespaces' 'cmd-basicresources[\ ]+bc\/ruby\-sample\-build' | ||
| echo "resource printer namespace handling: ok" |
There was a problem hiding this comment.
Instead of adding new tests to this suite, let's break out resource printer tests from basicresources
There was a problem hiding this comment.
Will do, I can make a new PR that does this
|
LGTM |
|
@fabianofranz hold on... we need to be treating our tests better. More tests should not go into |
Done! |
| trap os::test::junit::reconcile_output EXIT | ||
|
|
||
| # Test that resource printer includes resource kind on multiple resources | ||
| os::test::junit::declare_suite_start "cmd/basicresources/get" |
There was a problem hiding this comment.
if this is a suite for the resource printer, I think we should rename it that instead of get
juanvallejo
force-pushed
the
jvallejo_show-namespace-for-custom-bc
branch
from
7e27a34 to
3359206
Compare
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7811/) (Image: devenv-rhel7_4807) |
|
Evaluated for origin merge up to 3359206 |
|
@openshift-bot, the last build failed from the following flakes:
re[test] |
|
Evaluated for origin test up to 3359206 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7811/) |
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1365460
If there is a
bcusing a custom strategy,oc get all --all-namespacesdoes not show namespace for thatbc.cc @fabianofranz