Added support for project network isolation #10365
Conversation
pravisankar
force-pushed
the
support-project-isolation
branch
from
50fe5b2 to
6548c75
Compare
|
@openshift/networking PTAL |
| value, ok := netns.Annotations[ChangePodNetworkAnnotation] | ||
| if !ok { | ||
| return PodNetworkAction(""), "", ErrorPodNetworkAnnotationNotFound | ||
| } |
There was a problem hiding this comment.
you don't need the nil check; if it's nil, then "value, ok := ..." will return ok=false
pravisankar
force-pushed
the
support-project-isolation
branch
2 times, most recently
from
5f76b19 to
5c69e9f
Compare
|
[test] |
openshift-bot
added
the
needs-rebase
| netIDRange, err := pnetid.NewNetIDRange(osapi.MinVNID, osapi.MaxVNID-osapi.MinVNID+1) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("unable to create NetID range: %v", err) | ||
| } |
There was a problem hiding this comment.
You can only get an error here if there's a problem with the MinVNID/MaxVNID constants, which could never happen in production. So just panic if you get an error, and then newMasterVNIDMap() doesn't need to return an error.
(Also, maybe make NetNetIDRange() take min,max rather than min,size?)
|
LGTM other than noted. Not sure what's up with the test failure. |
ChangePodNetworkAnnotation will be processed by the SDN master controller. SDN master controller provides synchronization when manipulating vnids for namespaces.
- Split vnids.go based on master and node roles - Use netID allocator interface (bitmap instead of integer map) - Use ChangePodNetworkAnnotation on NetNamespace for VNID manipulation - Synchronize add/delete/update VNID operations - Added support for exposing project network isolation
…d of updating VNID directly This will ensure VNID is synchronized across add/delete/update operations.
pravisankar
force-pushed
the
support-project-isolation
branch
from
5c69e9f to
419be05
Compare
pravisankar
force-pushed
the
support-project-isolation
branch
from
419be05 to
047c65d
Compare
openshift-bot
removed
the
needs-rebase
|
Evaluated for origin test up to 047c65d |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7944/) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8067/) (Image: devenv-rhel7_4856) |
|
Evaluated for origin merge up to 047c65d |
|
Docs PR: openshift/openshift-docs#2673 |
Trello card: https://trello.com/c/RrVYvOJj/30-3-support-admin-cli-cmd-to-isolate-projects-sdn-functionality