Re-setup SDN on startup if ClusterNetworkCIDR changes #10569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should really just be using netlink for this so that we can more easily match exact routes, but LGTM. |
|
LGTM too... |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8335/) (Image: devenv-rhel7_4899) |
|
Evaluated for origin merge up to 73cc52b |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to 73cc52b |
|
LGTM |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8314/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We re-setup the SDN if the local subnet has changed, but not if the cluster-wide network has changed, meaning our instructions for how to change ClusterNetworkCIDR don't actually work. (I'm sure they did at one point, but we must have broken it... probably I added the clusternetwork-changing code during the period when the network-is-already-set-up code was totally broken and always returned false?)
Anyway, @openshift/networking PTAL