Skip to content

update invalid oc extract usage flag to "keys" #10614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Aug 24, 2016

Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1369371

oc extract --help uses the flag --only as example, but this flag has been replaced by --keys=[].
Using this flag with the command, renders the error: Error: unknown flag: --only.

This patch updates the help usage for this command to make use of the valid --keys=[] flag.

cc @fabianofranz

@fabianofranz
Copy link
Member

@juanvallejo I believe this requires updating the generated docs. @smarterclayton FYI

@juanvallejo juanvallejo force-pushed the jvallejo_update-invalid-oc-extract-flag branch from a6b9aae to 28325a5 Compare August 24, 2016 20:17
@juanvallejo
Copy link
Contributor Author

@fabianofranz

I believe this requires updating the generated docs

Thanks for catching that!

@juanvallejo
Copy link
Contributor Author

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 28325a5

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8407/)

1 similar comment
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8407/)

@fabianofranz
Copy link
Member

LGTM [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 25, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8460/) (Image: devenv-rhel7_4928)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 28325a5

@openshift-bot openshift-bot merged commit 56c27b5 into openshift:master Aug 26, 2016
@juanvallejo juanvallejo deleted the jvallejo_update-invalid-oc-extract-flag branch August 26, 2016 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants