Skip to content

Pullthrough typos in oc tag #13015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/generated/oc_by_example_content.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -2948,7 +2948,7 @@ Tag existing images into image streams
# Tag an external Docker image.
oc tag --source=docker openshift/origin:latest yourproject/ruby:tip

# Tag an external Docker image and request pull-trough for it.
# Tag an external Docker image and request pullthrough for it.
oc tag --source=docker openshift/origin:latest yourproject/ruby:tip --reference-policy=local


Expand Down
4 changes: 2 additions & 2 deletions docs/man/man1/oc-tag.1
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Pass the \-\-insecure flag if your external registry does not have a valid HTTPS

.PP
\fB\-\-reference\-policy\fP="source"
Allow to request pull\-trough for external image when set to 'local'. Defaults to 'source'.
Allow to request pullthrough for external image when set to 'local'. Defaults to 'source'.

.PP
\fB\-\-scheduled\fP=false
Expand Down Expand Up @@ -140,7 +140,7 @@ Pass the \-\-insecure flag if your external registry does not have a valid HTTPS
# Tag an external Docker image.
oc tag \-\-source=docker openshift/origin:latest yourproject/ruby:tip

# Tag an external Docker image and request pull\-trough for it.
# Tag an external Docker image and request pullthrough for it.
oc tag \-\-source=docker openshift/origin:latest yourproject/ruby:tip \-\-reference\-policy=local


Expand Down
4 changes: 2 additions & 2 deletions docs/man/man1/openshift-cli-tag.1
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Pass the \-\-insecure flag if your external registry does not have a valid HTTPS

.PP
\fB\-\-reference\-policy\fP="source"
Allow to request pull\-trough for external image when set to 'local'. Defaults to 'source'.
Allow to request pullthrough for external image when set to 'local'. Defaults to 'source'.

.PP
\fB\-\-scheduled\fP=false
Expand Down Expand Up @@ -140,7 +140,7 @@ Pass the \-\-insecure flag if your external registry does not have a valid HTTPS
# Tag an external Docker image.
openshift cli tag \-\-source=docker openshift/origin:latest yourproject/ruby:tip

# Tag an external Docker image and request pull\-trough for it.
# Tag an external Docker image and request pullthrough for it.
openshift cli tag \-\-source=docker openshift/origin:latest yourproject/ruby:tip \-\-reference\-policy=local


Expand Down
4 changes: 2 additions & 2 deletions pkg/cmd/cli/cmd/tag.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ var (
# Tag an external Docker image.
%[1]s tag --source=docker openshift/origin:latest yourproject/ruby:tip

# Tag an external Docker image and request pull-trough for it.
# Tag an external Docker image and request pullthrough for it.
%[1]s tag --source=docker openshift/origin:latest yourproject/ruby:tip --reference-policy=local


Expand Down Expand Up @@ -102,7 +102,7 @@ func NewCmdTag(fullName string, f *clientcmd.Factory, out io.Writer) *cobra.Comm
cmd.Flags().BoolVar(&opts.referenceTag, "reference", false, "Should the destination tag continue to pull from the source namespace. Defaults to false.")
cmd.Flags().BoolVar(&opts.scheduleTag, "scheduled", false, "Set a Docker image to be periodically imported from a remote repository. Defaults to false.")
cmd.Flags().BoolVar(&opts.insecureTag, "insecure", false, "Set to true if importing the specified Docker image requires HTTP or has a self-signed certificate. Defaults to false.")
cmd.Flags().StringVar(&opts.referencePolicy, "reference-policy", sourceReferencePolicy, "Allow to request pull-trough for external image when set to 'local'. Defaults to 'source'.")
cmd.Flags().StringVar(&opts.referencePolicy, "reference-policy", sourceReferencePolicy, "Allow to request pullthrough for external image when set to 'local'. Defaults to 'source'.")

return cmd
}
Expand Down