Skip to content

Set DeleteStrategy for all Openshift resources #14337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2017
Merged

Set DeleteStrategy for all Openshift resources #14337

merged 3 commits into from
May 30, 2017

Conversation

enj
Copy link
Contributor

@enj enj commented May 25, 2017

DeleteStrategy is no longer optional, and thus must be set by all resources.

Fixes #14198

[test]

Seeing a lot of this in master log so something is off:

E0524 20:01:04.267911   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all deployments.extensions in the cluster
E0524 20:01:04.280280   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all pods in the cluster
E0524 20:01:04.295723   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all statefulsets.apps in the cluster
E0524 20:01:04.329384   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all configmaps in the cluster
E0524 20:01:04.332520   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all poddisruptionbudgets.policy in the cluster
E0524 20:01:04.353559   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all cronjobs.batch in the cluster
E0524 20:01:04.354711   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all daemonsets.extensions in the cluster
E0524 20:01:04.354913   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all clusterrolebindings.rbac.authorization.k8s.io in the cluster
E0524 20:01:04.360645   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all groups.user.openshift.io in the cluster
E0524 20:01:04.391837   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all networkpolicies.extensions in the cluster
E0524 20:01:04.409736   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all serviceaccounts in the cluster
E0524 20:01:04.449994   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all netnamespaces.network.openshift.io in the cluster
E0524 20:01:04.465373   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all hostsubnets.network.openshift.io in the cluster
E0524 20:01:04.484305   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all podpresets.settings.k8s.io in the cluster
E0524 20:01:04.486138   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all deploymentconfigs.apps.openshift.io in the cluster
E0524 20:01:04.513420   27268 reflector.go:201] github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/controller/garbagecollector/graph_builder.go:192: Failed to list <nil>: User "system:serviceaccount:kube-system:generic-garbage-collector" cannot list all buildconfigs.build.openshift.io in the cluster

enj added 3 commits May 24, 2017 19:30
@enj
UPSTREAM: 46390: Require DeleteStrategy for all registry.Store
a9ac121 
All registry.Store objects already set a non-nil DeleteStrategy.
This change ensures that all future objects do so as well.

Signed-off-by: Monis Khan <[email protected]>
@enj
Set DeleteStrategy for all Openshift resources
e71a36b 
DeleteStrategy is no longer optional, and thus must be set by all
resources.

Signed-off-by: Monis Khan <[email protected]>
@enj
UPSTREAM: revert: 54d84e6: 24153: make optional generic etcd fields o…
00d9a88 
…ptional

Signed-off-by: Monis Khan <[email protected]>
@enj enj requested review from liggitt and deads2k May 25, 2017 00:10
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 00d9a88

@enj
Copy link
Contributor Author

enj commented May 25, 2017

You should also be able to write a unit test with some reflection magic against the storage map we make when we wire up the API server to catch these.

@deads2k I can add said test as a separate PR if you think it is necessary on top of the changes to CompleteWithOptions.

@enj
Copy link
Contributor Author

enj commented May 25, 2017

The errors in API server logs occur in master branch as well so not related to this PR.

cc @smarterclayton

@enj
Copy link
Contributor Author

enj commented May 25, 2017

cc @spadgett @jwforres @benjaminapetersen if any of you guys want to see if this fixes the web console issue.

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1727/) (Base Commit: 423315b)

@smarterclayton
Copy link
Contributor

LGTM - let me know if this fixes web console.

@spadgett
Copy link
Member

Thanks will test in the morning

@deads2k
Copy link
Contributor

deads2k commented May 25, 2017

@deads2k I can add said test as a separate PR if you think it is necessary on top of the changes to CompleteWithOptions.

If your upstream merges, I'm ok with it.

@mfojtik
Copy link
Contributor

mfojtik commented May 25, 2017

LGTM (guess this qualifies as bug fix).

@jwforres
Copy link
Member

confirmed on @enj 's machine that delete route from the console works now

@jwforres
Copy link
Member

@mfojtik and yeah this definitely qualifies as a bug fix, otherwise you wont be able to delete routes in the console

@enj
Copy link
Contributor Author

enj commented May 25, 2017

I will merge this once kubernetes/kubernetes/pull/46390 is merged.

@mfojtik
Copy link
Contributor

mfojtik commented May 30, 2017

upstream PR is now approved for merge

[merge][severity:bug]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 00d9a88

@openshift-bot
Copy link
Contributor

openshift-bot commented May 30, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/839/) (Base Commit: 39664e5) (Extended Tests: bug) (Image: devenv-rhel7_6281)

@liggitt
Copy link
Contributor

liggitt commented May 30, 2017

[severity:blocker]

@openshift-bot openshift-bot merged commit b2dfb64 into openshift:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@deads2k deads2k Awaiting requested review from deads2k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@enj @openshift-bot @smarterclayton @spadgett @deads2k @mfojtik @jwforres @liggitt