-
Notifications
You must be signed in to change notification settings - Fork 4.7k
UPSTREAM: 47003: Remove duplicate errors from an aggregate error input. #14495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 47003: Remove duplicate errors from an aggregate error input. #14495
Conversation
0d873f0
to
bc29c05
Compare
Do not merge yet as discussions are still going on in upstream kube PR. |
bc29c05
to
855d721
Compare
[merge][severity:blocker] |
|
@smarterclayton looking. |
…t. Helps Helps with some scheduler errors that fill the log enormously.
Its happening because golang-1.7 does not understand sort.Slice whereas golang 1.8 does. Would it be ok to remove the unit test part and just have the main code? |
hmm, can we write go 1.7 style sort? would make any other future backport requests not awful. |
855d721
to
77a6bb2
Compare
@derekwaynecarr I have updated this PR to make sorting work with go 1.7. I have put same upstream PR number: UPSTREAM: 47003 for these extra changes not in upstream kube. |
[merge][severity:blocker] |
Evaluated for origin merge up to 77a6bb2 |
[Test]ing while waiting on the merge queue |
Evaluated for origin test up to 77a6bb2 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2317/) (Base Commit: 4aa3720) (PR Branch Commit: 77a6bb2) |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1028/) (Base Commit: 8c017d2) (PR Branch Commit: 77a6bb2) (Extended Tests: blocker) (Image: devenv-rhel7_6374) |
@derekwaynecarr
As the upstream PR kubernetes/kubernetes#47003 is merged now, I have updated this PR.