Increase default max in flight requests and lengthen short timeouts #15129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc: @jeremyeder |
liggitt
reviewed
Jul 11, 2017
| @@ -32,7 +32,7 @@ func addDefaultingFuncs(scheme *runtime.Scheme) error { | |||
| obj.ServingInfo.RequestTimeoutSeconds = 60 * 60 | |||
| } | |||
| if obj.ServingInfo.MaxRequestsInFlight == 0 { | |||
| obj.ServingInfo.MaxRequestsInFlight = 500 | |||
There was a problem hiding this comment.
@deads2k will need to pull into the rebase PR
|
Shouldn't the upstream be an actual commit rather than a carry? |
|
I don't know whether we want to have the longer timeouts upstream or not.
David wanted to plumb an option and I don't want to do that right now.
…On Mon, Jul 10, 2017 at 10:36 PM, Jordan Liggitt ***@***.***> wrote:
Shouldn't the upstream be an actual commit rather than a carry?
LGTM otherwise
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15129 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p1y5YB8jEE00xa6zEfUpowrHapNxks5sMt-3gaJpZM4OTogF>
.
|
|
For 3.6 or 3.7? |
|
[test]
…On Tue, Jul 11, 2017 at 12:55 AM, OpenShift Bot ***@***.***> wrote:
continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3041/)
(Base Commit: d4f473a
<d4f473a>)
(PR Branch Commit: 57808db
<57808db>
)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15129 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p9zLLAhpDKfAqkw5JAIjIJkm89yoks5sMwAygaJpZM4OTogF>
.
|
|
3.6 |
Will reevaluate in the future
In practice, with etcd3 + protobuf this number is more appropriate to scale out clusters.
|
@liggitt bumped both of those timeouts to 5 minutes |
|
LGTM |
|
Evaluated for origin test up to 4132c49 |
|
[severity:blocker] |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3054/) (Base Commit: 1c8af8b) (PR Branch Commit: 4132c49) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very large clusters configured with
openshift start masternow are unable to startup. We support existing clusters installed in this fashion (this is how single master installs work today unless the user specifiesetcd_host)Increase two default vendored timeouts to be longer. Max in flight is increased to 1200 out of the box because it matches to reasonably large clusters.
[test] @liggitt