use init containers to pull down build inputs #15248

bparees · 2017-07-17T21:20:45Z

No description provided.

bparees · 2017-07-24T20:54:26Z

[test]

openshift-merge-robot · 2017-07-25T19:05:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bparees

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-merge-robot · 2017-07-25T19:07:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bparees

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-merge-robot · 2017-07-25T19:08:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bparees

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

deads2k · 2017-07-26T20:11:08Z

/assign bparees
/unassign

openshift-merge-robot · 2017-07-28T22:12:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bparees

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

openshift-merge-robot · 2017-07-28T22:14:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bparees

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

bparees · 2017-08-11T19:42:51Z

/test extended_builds

bparees · 2017-08-12T03:46:09Z

/test extended_builds

bparees · 2017-08-12T15:45:02Z

/test extended_builds

bparees · 2017-08-12T16:25:35Z

/test extended_builds

bparees · 2017-08-14T03:18:44Z

/retest

bparees · 2017-08-14T22:22:52Z

/test extended_builds

bparees · 2017-08-15T00:19:36Z

/test extended_builds

bparees · 2017-08-15T03:34:46Z

/test extended_builds

bparees · 2017-08-15T14:54:56Z

@openshift/devex woo, this is passing all tests including extended builds. please take another look/pass, i'd like to merge it tomorrow so it gets as much soak time in 3.7 as possible.

gabemontero · 2017-08-15T15:00:25Z

pkg/build/builder/cmd/builder.go

-			return sourceSecretDir, nil, fmt.Errorf("cannot fix source secret permissions: %v", errSecret)
-		}
-		secretsEnv, overrideURL, err := scmAuths.Setup(sourceSecretDir)
+		secretsEnv, overrideURL, err := scmAuths.Setup(c.sourceSecretDir)


is the TODO comment above still relevant?

nope, should have been removed, thanks.

csrwng

Really minor nit, otherwise lgtm

csrwng · 2017-08-15T19:32:34Z

pkg/build/builder/common.go

@@ -185,7 +195,7 @@ func updateBuildRevision(build *buildapi.Build, sourceInfo *git.SourceInfo) *bui

 // handleBuildStatusUpdate handles updating the build status


s/handle/Handle/

thx, fixed.

bparees · 2017-08-16T17:25:11Z

merging on @csrwng's lgtm.

csrwng · 2017-08-16T19:24:33Z

don't you need to remove the do-not-merge label?

bparees · 2017-08-16T20:01:33Z

thanks @csrwng :)

openshift-merge-robot · 2017-08-16T23:30:57Z

Automatic merge from submit-queue (batch tested with PRs 15786, 15732, 15248, 15780)

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2017

bparees force-pushed the init_containers3 branch from 35a34d1 to 9f9aadd Compare July 19, 2017 02:13

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2017

bparees force-pushed the init_containers3 branch 2 times, most recently from 959d2e4 to 4e9d721 Compare July 21, 2017 20:16

openshift-merge-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 24, 2017

bparees force-pushed the init_containers3 branch from dcdecbe to 79c1308 Compare July 24, 2017 19:57

openshift-merge-robot assigned deads2k and tdawson Jul 25, 2017

tdawson removed their assignment Jul 25, 2017

openshift-ci-robot assigned bparees and unassigned deads2k Jul 26, 2017

openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017

openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017

openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2017

bparees force-pushed the init_containers3 branch 2 times, most recently from a09aa41 to 8784f17 Compare August 2, 2017 20:04

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2017

bparees force-pushed the init_containers3 branch from 8784f17 to 77a3656 Compare August 2, 2017 20:09

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2017

bparees force-pushed the init_containers3 branch from eeb8f2b to 1c403a6 Compare August 3, 2017 20:15

openshift-merge-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 3, 2017

bparees added the do-not-merge label Aug 11, 2017

bparees added 2 commits August 11, 2017 23:45

handle missing build contextdir and fetch source errors

ce911b6

handle streaming logs for containers that ultimately fail

b3998b9

bparees force-pushed the init_containers3 branch from 4859e42 to b3998b9 Compare August 12, 2017 03:46

make unit test list comparison order-independent

8604e91

bparees force-pushed the init_containers3 branch from f95f2b0 to 8604e91 Compare August 12, 2017 16:17

fix git source secret handling

b5d9751

bparees force-pushed the init_containers3 branch from 5bc28ac to b5d9751 Compare August 15, 2017 00:19

gabemontero reviewed Aug 15, 2017

View reviewed changes

gabe3

c177630

csrwng reviewed Aug 15, 2017

View reviewed changes

cesar2

554a246

bparees added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2017

bparees removed the do-not-merge label Aug 16, 2017

openshift-merge-robot merged commit fc6f023 into openshift:master Aug 16, 2017

bparees deleted the init_containers3 branch August 23, 2017 21:49

bparees mentioned this pull request Mar 10, 2022

BUILD-433: Run builds in user namespaces without seccomp if BUILD_PRIVILEGED=false openshift/openshift-controller-manager#173

Merged

		@@ -185,7 +195,7 @@ func updateBuildRevision(build buildapi.Build, sourceInfo git.SourceInfo) *bui

		// handleBuildStatusUpdate handles updating the build status

use init containers to pull down build inputs #15248

use init containers to pull down build inputs #15248

Uh oh!

Conversation

bparees commented Jul 17, 2017

Uh oh!

bparees commented Jul 24, 2017

Uh oh!

openshift-merge-robot commented Jul 25, 2017

Uh oh!

openshift-merge-robot commented Jul 25, 2017

Uh oh!

openshift-merge-robot commented Jul 25, 2017

Uh oh!

deads2k commented Jul 26, 2017

Uh oh!

openshift-merge-robot commented Jul 28, 2017

Uh oh!

openshift-merge-robot commented Jul 28, 2017

Uh oh!

bparees commented Aug 11, 2017

Uh oh!

bparees commented Aug 12, 2017

Uh oh!

bparees commented Aug 12, 2017

Uh oh!

bparees commented Aug 12, 2017

Uh oh!

bparees commented Aug 14, 2017

Uh oh!

bparees commented Aug 14, 2017

Uh oh!

bparees commented Aug 15, 2017

Uh oh!

bparees commented Aug 15, 2017

Uh oh!

bparees commented Aug 15, 2017

Uh oh!

gabemontero Aug 15, 2017

Choose a reason for hiding this comment

Uh oh!

bparees Aug 15, 2017

Choose a reason for hiding this comment

Uh oh!

csrwng left a comment

Choose a reason for hiding this comment

Uh oh!

csrwng Aug 15, 2017

Choose a reason for hiding this comment

Uh oh!

bparees Aug 15, 2017

Choose a reason for hiding this comment

Uh oh!

bparees commented Aug 16, 2017

Uh oh!

csrwng commented Aug 16, 2017

Uh oh!

bparees commented Aug 16, 2017

Uh oh!

openshift-merge-robot commented Aug 16, 2017

Uh oh!

Uh oh!