Skip to content

Add ImageStream API resource to replace ImageRepository, mark IR deprecated #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2015
Merged

Add ImageStream API resource to replace ImageRepository, mark IR deprecated #1525

merged 2 commits into from
Apr 2, 2015

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Mar 31, 2015

No description provided.

@ncdc ncdc force-pushed the image-stream branch 5 times, most recently from d547dbf to b3b1254 Compare April 1, 2015 16:36
@ncdc
Copy link
Contributor Author

ncdc commented Apr 1, 2015

[test]

@ncdc ncdc force-pushed the image-stream branch 3 times, most recently from bd8b08f to 7156c12 Compare April 2, 2015 02:10
This was referenced Apr 2, 2015
Closed
Closed
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1688/)

@ncdc ncdc force-pushed the image-stream branch 2 times, most recently from 1ae61c0 to a5e2108 Compare April 2, 2015 15:10
@ncdc
Copy link
Contributor Author

ncdc commented Apr 2, 2015

[test]

1 similar comment
@ncdc
Copy link
Contributor Author

ncdc commented Apr 2, 2015

[test]

@smarterclayton
Copy link
Contributor

This is LGTM, we can clean it up afterwards. A few things like ensuring tags have a consistent ordering (which might mean we can't use the map internally) can be done afterwards. Merge when you get a green.

@ncdc ncdc changed the title WIP: Deprecate ImageRepository, Add ImageStream Deprecate ImageRepository, Add ImageStream Apr 2, 2015
@ncdc
Copy link
Contributor Author

ncdc commented Apr 2, 2015

Getting tired of these flakey hack/test-cmd.sh: line 73: openshift: command not found failures, grrr

@smarterclayton
Copy link
Contributor

That sounds new... Do we have an issue open and someone assigned to triage it?

On Apr 2, 2015, at 2:32 PM, Andy Goldstein [email protected] wrote:

Getting tired of these flakey hack/test-cmd.sh: line 73: openshift: command not found failures, grrr

—
Reply to this email directly or view it on GitHub.

@ncdc
Copy link
Contributor Author

ncdc commented Apr 2, 2015

@smarterclayton it pops up every so often. I've been seeing it every so often for a long time now, but not enough to be annoying. I'll file an issue.

@ncdc
Copy link
Contributor Author

ncdc commented Apr 2, 2015

Opened #1579 for the flakey failure

@ncdc
Copy link
Contributor Author

ncdc commented Apr 2, 2015

[test]

1 similar comment
@ncdc
Copy link
Contributor Author

ncdc commented Apr 2, 2015

[test]

@ncdc
Copy link
Contributor Author

ncdc commented Apr 2, 2015

GREEN!!!!!

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1444/) (Image: devenv-fedora_1191)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 61a8212

openshift-bot pushed a commit that referenced this pull request Apr 2, 2015
Merge pull request #1525 from ncdc/image-stream
45786ae 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 45786ae into openshift:master Apr 2, 2015
soltysh added a commit to soltysh/origin that referenced this pull request Apr 7, 2015
@soltysh
Updated openshift#1525 leftovers in sample-app
f47fa8b
soltysh added a commit to soltysh/origin that referenced this pull request Apr 7, 2015
@soltysh
Updated openshift#1525 leftovers in sample-app
0940f49
@smarterclayton smarterclayton changed the title Deprecate ImageRepository, Add ImageStream Add ImageStream API resource to replace ImageRepository, mark IR deprecated Apr 8, 2015
@ncdc ncdc deleted the image-stream branch April 10, 2015 13:35
@smarterclayton
Copy link
Contributor

deploy_trigger_test is commented out - can you restore that?

jpeeler pushed a commit to jpeeler/origin that referenced this pull request Nov 19, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
60e970d 
…service-catalog/' changes from 3064247d05..d969acde90

d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583)
1bcd53b684 origin build: add origin tooling
bb3e4a1 Chart changes for 0.1.3 (openshift#1573)
1d463c3 less etcd logs during integration test (openshift#1572)
dcdb82d Fixing coverage tool. It had double 'contrib' on script path. (openshift#1568)
b636203 make binding poll function clone binding (openshift#1550)
e8e5baa Do not block instance spec changes unless there is an on-going operation (openshift#1536)
4f47ce8 Embed etcd in the integration tests directly. (openshift#1570)
d02ac34 Make logging in admission controllers consistent with controller-manager (openshift#1519)
31ae521 Check if file permissions allow go install (openshift#1566)
52e64db Clear out plan ref when plan changed using k8s names (openshift#1553)
4b49594 Allow deprovision after change to non-existent plan (openshift#1557)
c6e446e Consolidating logic for creating in-progress properties. (openshift#1511)
fd3a6d7 Adding UnbindStatus to ServiceBindings (openshift#1544)
b471bd3 Add tracer bullet integration test that shows dynamic response from fake broker. (openshift#1538)
c8d5610 update comments on NewStorage (openshift#1548)
35082df Update resources in walkthrough (openshift#1510)
f86b8aa Fix manual hack of glide.lock file from openshift#1517. (openshift#1543)
02a5ff6 Add an additional plan to ups-broker (openshift#1537)
4309a0e add alpha asynchronous binding operation support (openshift#1512)
617c823 Grant controller abilit to update service/plan status (openshift#1532)
281ca9c Moving a duplicated block of code to an independent function. (openshift#1509)
da5e9fa Use Event Builder to help construct expected error messages for controller_instance_test. (openshift#1507)
48c522d Updating helm install documentation (openshift#1525)
b89d59e Adding an independent test for originating_identity (openshift#1498)
6eb8a16 Apply Event Message Builder controller_broker unit tests (openshift#1497)
411831c Fixing missing pretty logging on controller_binding. (openshift#1520)
REVERT: 3064247d05 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: d969acde904f95538892ccd570c8c4ca447280bd
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Nov 20, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
cee61f2 
…service-catalog/' changes from 3064247d05..d969acde90

d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583)
1bcd53b684 origin build: add origin tooling
bb3e4a1 Chart changes for 0.1.3 (openshift#1573)
1d463c3 less etcd logs during integration test (openshift#1572)
dcdb82d Fixing coverage tool. It had double 'contrib' on script path. (openshift#1568)
b636203 make binding poll function clone binding (openshift#1550)
e8e5baa Do not block instance spec changes unless there is an on-going operation (openshift#1536)
4f47ce8 Embed etcd in the integration tests directly. (openshift#1570)
d02ac34 Make logging in admission controllers consistent with controller-manager (openshift#1519)
31ae521 Check if file permissions allow go install (openshift#1566)
52e64db Clear out plan ref when plan changed using k8s names (openshift#1553)
4b49594 Allow deprovision after change to non-existent plan (openshift#1557)
c6e446e Consolidating logic for creating in-progress properties. (openshift#1511)
fd3a6d7 Adding UnbindStatus to ServiceBindings (openshift#1544)
b471bd3 Add tracer bullet integration test that shows dynamic response from fake broker. (openshift#1538)
c8d5610 update comments on NewStorage (openshift#1548)
35082df Update resources in walkthrough (openshift#1510)
f86b8aa Fix manual hack of glide.lock file from openshift#1517. (openshift#1543)
02a5ff6 Add an additional plan to ups-broker (openshift#1537)
4309a0e add alpha asynchronous binding operation support (openshift#1512)
617c823 Grant controller abilit to update service/plan status (openshift#1532)
281ca9c Moving a duplicated block of code to an independent function. (openshift#1509)
da5e9fa Use Event Builder to help construct expected error messages for controller_instance_test. (openshift#1507)
48c522d Updating helm install documentation (openshift#1525)
b89d59e Adding an independent test for originating_identity (openshift#1498)
6eb8a16 Apply Event Message Builder controller_broker unit tests (openshift#1497)
411831c Fixing missing pretty logging on controller_binding. (openshift#1520)
REVERT: 3064247d05 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: d969acde904f95538892ccd570c8c4ca447280bd
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Dec 15, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
cedd00c 
…service-catalog/' changes from 3064247d05..d969acde90

d969acde90 Add additional service to ups-broker to fix e2e (openshift#1583)
1bcd53b684 origin build: add origin tooling
bb3e4a1 Chart changes for 0.1.3 (openshift#1573)
1d463c3 less etcd logs during integration test (openshift#1572)
dcdb82d Fixing coverage tool. It had double 'contrib' on script path. (openshift#1568)
b636203 make binding poll function clone binding (openshift#1550)
e8e5baa Do not block instance spec changes unless there is an on-going operation (openshift#1536)
4f47ce8 Embed etcd in the integration tests directly. (openshift#1570)
d02ac34 Make logging in admission controllers consistent with controller-manager (openshift#1519)
31ae521 Check if file permissions allow go install (openshift#1566)
52e64db Clear out plan ref when plan changed using k8s names (openshift#1553)
4b49594 Allow deprovision after change to non-existent plan (openshift#1557)
c6e446e Consolidating logic for creating in-progress properties. (openshift#1511)
fd3a6d7 Adding UnbindStatus to ServiceBindings (openshift#1544)
b471bd3 Add tracer bullet integration test that shows dynamic response from fake broker. (openshift#1538)
c8d5610 update comments on NewStorage (openshift#1548)
35082df Update resources in walkthrough (openshift#1510)
f86b8aa Fix manual hack of glide.lock file from openshift#1517. (openshift#1543)
02a5ff6 Add an additional plan to ups-broker (openshift#1537)
4309a0e add alpha asynchronous binding operation support (openshift#1512)
617c823 Grant controller abilit to update service/plan status (openshift#1532)
281ca9c Moving a duplicated block of code to an independent function. (openshift#1509)
da5e9fa Use Event Builder to help construct expected error messages for controller_instance_test. (openshift#1507)
48c522d Updating helm install documentation (openshift#1525)
b89d59e Adding an independent test for originating_identity (openshift#1498)
6eb8a16 Apply Event Message Builder controller_broker unit tests (openshift#1497)
411831c Fixing missing pretty logging on controller_binding. (openshift#1520)
REVERT: 3064247d05 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: d969acde904f95538892ccd570c8c4ca447280bd
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
@arschles @kibbles-n-bytes
Updating helm install documentation (openshift#1525)
48c522d 
To use the helm repository instead of the helm charts on local disk

Fixes
kubernetes-retired/service-catalog#1523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdc @openshift-bot @smarterclayton