Skip to content

Update list of allowed runAsUser types in the error message #15529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

php-coder
Copy link
Contributor

@php-coder php-coder commented Jul 28, 2017

MustRunAsRange strategy is missing in the list of valid strategies:

$ oc create -f total-restricted.yaml
The SecurityContextConstraints "total-restricted" is invalid: runAsUser.type: Invalid value: "MustRunAsRage": invalid strategy type. Valid values are MustRunAs, MustRunAsNonRoot, RunAsAny

This PR adds it.

PTAL @pweil- @simo5

@openshift-merge-robot openshift-merge-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@php-coder
Copy link
Contributor Author

/assign @enj

@php-coder php-coder force-pushed the fix_run_as_user_err_msg branch from a763d41 to ad677e3 Compare July 28, 2017 16:13
@php-coder
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@mfojtik
Copy link
Contributor

mfojtik commented Jul 31, 2017

/approve no-issue

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2017
@enj
Copy link
Contributor

enj commented Aug 1, 2017

/lgtm

Change is only to error message, no API or feature change.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, mfojtik, php-coder

Associated issue requirement bypassed by: mfojtik

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@stevekuznetsov
Copy link
Contributor

/test end_to_end

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15533, 15414, 15584, 15529, 15309)

@openshift-merge-robot openshift-merge-robot merged commit eb15783 into openshift:master Aug 2, 2017
@php-coder php-coder deleted the fix_run_as_user_err_msg branch August 2, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants