Enable Portworx Storage Driver #15862

adityadani · 2017-08-18T17:40:58Z

This change

Enables portworx storage driver through the kubernetes volume plugins API.
Reverts commit - dcb5eef
Removes the duplicate proto generation error.

openshift-ci-robot · 2017-08-18T17:41:07Z

Hi @adityadani. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

adityadani · 2017-08-18T17:42:48Z

@deads2k I have modified the vendor'ed directories used by Portworx plugin to remove the "duplicate proto registered" error.

deads2k · 2017-08-18T19:01:29Z

vendor/github.com/libopenstorage/openstorage/api/api.pb.go

@@ -7,7 +7,7 @@ package api
 import proto "github.com/golang/protobuf/proto"
 import fmt "fmt"
 import math "math"
-import google_protobuf "go.pedge.io/pb/go/google/protobuf"
+import google_protobuf "github.com/golang/protobuf/ptypes/timestamp"


@smarterclayton this is a carry and I don't know what it does. Do you?

Previously there were two different protobuf versions being used. I updated this vendor'ed code used by portworx to use the same protobuf version which others are using in openshift. Now we won't get the duplicate proto error.

Previously there were two different protobuf versions being used. I updated this vendor'ed code used by portworx to use the same protobuf version which others are using in openshift. Now we won't get the duplicate proto error.

Oh, ok. Then this isn't a carry. <carry> is a commit that updates code in a way that the upstream project rejected (or would reject if you know the project very well). What you have done is a bump. You should combine the code change the godep.json change into a single commit with a name like bump(github.com/libopenstorage/openstorage): a53f5e5662367da02b95470980c5dbaadfe96c99

commit with a name like bump(github.com/libopenstorage/openstorage): a53f5e5662367da02b95470980c5dbaadfe96c99

We use that format to be able to find when we picked up particular levels to find particular patches. A couple scripts rely on it.

I have updated the commits.

deads2k · 2017-08-18T19:02:02Z

Godeps/Godeps.json

@@ -2535,27 +2535,27 @@
 		},
 		{
 			"ImportPath": "github.com/libopenstorage/openstorage/api",
-			"Rev": "6e787003b91ddba85f108b8aede075b1af0d3606"
+			"Rev": "a53f5e5662367da02b95470980c5dbaadfe96c99"


Why did this bump if you have made a carry commit? Did something else change?

I might have understood the meaning of "carry" differently.
I updated this vendor'ed file to that particular commit. Should the commit message then be different?

adityadani · 2017-08-23T20:19:40Z

@deads2k @smarterclayton Can you enable tests on this PR ?

smarterclayton · 2017-08-23T23:49:01Z

/ok-to-test

deads2k · 2017-08-24T11:01:28Z

I have updated the commits.

Thanks

/lgtm

openshift-bot · 2017-08-24T14:58:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

deads2k · 2017-08-24T17:44:46Z

job died. I'm going to cancel the rest to free the queue and retest

deads2k · 2017-08-24T17:46:29Z

/retest

deads2k · 2017-08-24T18:36:27Z

/retest

adityadani · 2017-08-24T22:18:54Z

The extended _conformance_install_update failed with this error :
Removing containers and the following error:
rm: cannot remove ‘/tmp/etcd/openshift-backup-etcd_backup_tag20170824144459’: Permission denied
@deads2k Is this an intermittent error ?

openshift-bot · 2017-08-25T15:10:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

deads2k · 2017-08-25T18:55:57Z

The extended _conformance_install_update failed with this error :
Removing containers and the following error:
rm: cannot remove ‘/tmp/etcd/openshift-backup-etcd_backup_tag20170824144459’: Permission denied
@deads2k Is this an intermittent error ?

it is :( . We're battling a few flakes at the moment. Looks like the bot got you sorted.

openshift-bot · 2017-08-26T07:18:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

adityadani · 2017-08-29T18:30:14Z

@deads2k I had to rebase my changes to fix some conflicts. Can you add the lgtm back? Also the flaky test failed again in the previous run.

…oid double proto registration" This reverts commit dcb5eef.

…80c5dbaadfe96c99

deads2k · 2017-08-30T13:48:23Z

/retest
/lgtm

openshift-merge-robot · 2017-08-30T13:48:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adityadani, deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

deads2k · 2017-08-30T13:48:49Z

bumping queue priority since its getting stuck in rebases.

adityadani · 2017-08-30T17:55:56Z

/retest

openshift-merge-robot · 2017-08-30T20:22:22Z

/test all [submit-queue is verifying that this PR is safe to merge]

openshift-ci-robot · 2017-08-30T21:20:01Z

@adityadani: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/unit	`128f452`	link	`/test unit`
ci/openshift-jenkins/extended_conformance_gce	`128f452`	link	`/test extended_conformance_gce`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot · 2017-08-30T22:09:23Z

Automatic merge from submit-queue (batch tested with PRs 15862, 15781, 15944)

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2017

openshift-merge-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 18, 2017

openshift-merge-robot assigned liggitt and smarterclayton Aug 18, 2017

adityadani force-pushed the portworx branch from 78d3b33 to 534099b Compare August 18, 2017 18:45

openshift-merge-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 18, 2017

deads2k reviewed Aug 18, 2017

View reviewed changes

adityadani force-pushed the portworx branch from 534099b to 45f0d13 Compare August 18, 2017 19:25

openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 23, 2017

openshift-ci-robot assigned deads2k Aug 24, 2017

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2017

openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2017

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2017

adityadani force-pushed the portworx branch from 45f0d13 to c777d1c Compare August 29, 2017 18:28

openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2017

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2017

adityadani added 3 commits August 29, 2017 19:57

Enable Portworx Volumes.

3424697

UPSTREAM: revert: dcb5eef: "UPSTREAM: <drop>: hack out portworx to av…

34d9d7c

…oid double proto registration" This reverts commit dcb5eef.

bump(github.com/libopenstorage/openstorage): a53f5e5662367da02b954709…

128f452

…80c5dbaadfe96c99

adityadani force-pushed the portworx branch from c777d1c to 128f452 Compare August 29, 2017 18:58

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2017

deads2k added the queue/multiple-rebases label Aug 30, 2017

openshift-merge-robot merged commit 4a85dec into openshift:master Aug 30, 2017

adityadani mentioned this pull request Aug 30, 2017

re-enable portworx #15269

Closed

Enable Portworx Storage Driver #15862

Enable Portworx Storage Driver #15862

Uh oh!

Conversation

adityadani commented Aug 18, 2017

Uh oh!

openshift-ci-robot commented Aug 18, 2017

Uh oh!

adityadani commented Aug 18, 2017

Uh oh!

deads2k Aug 18, 2017

Choose a reason for hiding this comment

Uh oh!

adityadani Aug 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deads2k Aug 18, 2017

Choose a reason for hiding this comment

Uh oh!

deads2k Aug 18, 2017

Choose a reason for hiding this comment

Uh oh!

adityadani Aug 18, 2017

Choose a reason for hiding this comment

Uh oh!

deads2k Aug 18, 2017

Choose a reason for hiding this comment

Uh oh!

adityadani Aug 18, 2017

Choose a reason for hiding this comment

Uh oh!

adityadani commented Aug 23, 2017

Uh oh!

smarterclayton commented Aug 23, 2017

Uh oh!

deads2k commented Aug 24, 2017

Uh oh!

openshift-bot commented Aug 24, 2017

Uh oh!

deads2k commented Aug 24, 2017

Uh oh!

deads2k commented Aug 24, 2017

Uh oh!

deads2k commented Aug 24, 2017

Uh oh!

adityadani commented Aug 24, 2017

Uh oh!

openshift-bot commented Aug 25, 2017

Uh oh!

deads2k commented Aug 25, 2017

Uh oh!

openshift-bot commented Aug 26, 2017

Uh oh!

adityadani commented Aug 29, 2017

Uh oh!

deads2k commented Aug 30, 2017

Uh oh!

openshift-merge-robot commented Aug 30, 2017

Uh oh!

deads2k commented Aug 30, 2017

Uh oh!

adityadani commented Aug 30, 2017

Uh oh!

openshift-merge-robot commented Aug 30, 2017

Uh oh!

openshift-ci-robot commented Aug 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-robot commented Aug 30, 2017

Uh oh!

Uh oh!

adityadani Aug 18, 2017 •

edited

Loading

openshift-ci-robot commented Aug 30, 2017 •

edited

Loading