switch to go 1.9 #17670

deads2k · 2017-12-07T20:34:46Z

/assign skuznets

needed to land the rebase

openshift-ci-robot · 2017-12-07T20:34:47Z

@deads2k: GitHub didn't allow me to assign the following users: skuznets.

Note that only openshift members can be assigned.

In response to this:

/assign skuznets

needed to land the rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

imcsk8 · 2017-12-07T20:40:45Z

LGTM

deads2k · 2017-12-07T20:57:44Z

@stevekuznetsov fail

stevekuznetsov · 2017-12-07T21:03:58Z

Fixed in openshift-eng/aos-cd-jobs#928

/test verify

deads2k · 2017-12-07T21:22:36Z

/retest

stevekuznetsov · 2017-12-07T21:49:08Z

[INFO] Detected go version: go version go1.9 linux/amd64.
[FATAL] Please install Go version go1.9 or use PERMISSIVE_GO=y to bypass this check.

FUN.

deads2k · 2017-12-07T22:16:05Z

/retest

deads2k · 2017-12-07T22:57:39Z

[INFO] Detected go version: go version go1.9 linux/amd64.
[FATAL] Please install Go version go1.9 or use PERMISSIVE_GO=y to bypass this check.
FUN.

hacked the check out.

deads2k · 2017-12-08T02:07:34Z

/retest

I'll update unit tomorrow

openshift-ci-robot · 2017-12-08T16:12:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~hack/lib/OWNERS~~ [deads2k]
~~vendor/k8s.io/kubernetes/pkg/master/OWNERS~~ [deads2k]
~~vendor/k8s.io/kubernetes/plugin/pkg/admission/OWNERS~~ [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

stevekuznetsov · 2017-12-08T20:18:11Z

So here is our snafu:

we still have not either containerized or gotten rid of the dependency on the Docker daemon for the end-to-end suite
that suite uses go test to run integration-type tests that touch the Docker daemon directly
that action requires go of the correct version on the host
upgrading go on the host is only possible (without crazy hacks) in the base AMI for all jobs for all repos

I think the best course of action today is:

merge the refactors in this PR (as long as they are compatible with 1.8)
move all CI to 1.9
merge the bash bits

soltysh · 2017-12-11T10:48:06Z

hack/lib/util/golang.sh

@@ -11,7 +11,8 @@ function os::golang::verify_go_version() {
 	if [[ "${go_version[2]}" != go1.8* ]]; then


This should be OS_REQUIRED_GO_VERSION

This should be OS_REQUIRED_GO_VERSION

done

…ang 1.9

deads2k · 2017-12-11T13:02:54Z

I think the best course of action today is:

merge the refactors in this PR (as long as they are compatible with 1.8)
move all CI to 1.9
merge the bash bits

I'll split the bits apart. We'll need to green button them in.

openshift-ci-robot · 2017-12-11T14:16:51Z

@deads2k: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/verify	`65db132`	link	`/test verify`
ci/openshift-jenkins/end_to_end	`65db132`	link	`/test end_to_end`
ci/openshift-jenkins/extended_conformance_gce	`65db132`	link	`/test extended_conformance_gce`
ci/openshift-jenkins/extended_conformance_install	`65db132`	link	`/test extended_conformance_install`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh

lgtm

liggitt · 2017-12-12T17:39:07Z

move all CI to 1.9

does that mean 3.6, 3.7, 3.8 cannot run CI? or do we have a base AMI per branch?

stevekuznetsov · 2017-12-12T22:00:17Z

Historically no, Origin does not test older versions. OSE does.

stevekuznetsov · 2017-12-12T22:01:11Z

Well, not quite -- the tests running inside of a container (all but registry and router integration) use the Go version declared in the repo under hack/ and select the correct version regardless of the AMI.

deads2k · 2017-12-13T20:12:19Z

no longer required. I think #17755 is the dangling bit now.

stevekuznetsov · 2017-12-13T21:15:23Z

/close

openshift-ci-robot requested review from fabianofranz and 0xmichalis December 7, 2017 20:34

deads2k assigned stevekuznetsov Dec 7, 2017

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2017

deads2k force-pushed the golang-1.9 branch 2 times, most recently from ae8d1ab to 2fd7d5b Compare December 7, 2017 20:37

deads2k force-pushed the golang-1.9 branch from 2fd7d5b to 39a067c Compare December 7, 2017 22:57

openshift-merge-robot added the vendor-update Touching vendor dir or related files label Dec 8, 2017

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2017

soltysh suggested changes Dec 11, 2017

View reviewed changes

deads2k added 3 commits December 11, 2017 08:00

switch to go 1.9

57f30fa

UPSTREAM: <drop>: add type toleration needed for golang 1.9

3f6e873

UPSTREAM: <drop>: remove this from fork, disable 1.8 test to move gol…

65db132

…ang 1.9

deads2k force-pushed the golang-1.9 branch from fed2e71 to 65db132 Compare December 11, 2017 13:00

deads2k mentioned this pull request Dec 11, 2017

Tolerate 1.9 #17711

Closed

soltysh approved these changes Dec 12, 2017

View reviewed changes

openshift-ci-robot closed this Dec 13, 2017

deads2k deleted the golang-1.9 branch January 24, 2018 14:38

		@@ -11,7 +11,8 @@ function os::golang::verify_go_version() {
		if [[ "${go_version[2]}" != go1.8* ]]; then

switch to go 1.9 #17670

switch to go 1.9 #17670

Uh oh!

Conversation

deads2k commented Dec 7, 2017

Uh oh!

openshift-ci-robot commented Dec 7, 2017

Uh oh!

imcsk8 commented Dec 7, 2017

Uh oh!

deads2k commented Dec 7, 2017

Uh oh!

stevekuznetsov commented Dec 7, 2017

Uh oh!

deads2k commented Dec 7, 2017

Uh oh!

stevekuznetsov commented Dec 7, 2017

Uh oh!

deads2k commented Dec 7, 2017

Uh oh!

deads2k commented Dec 7, 2017

Uh oh!

deads2k commented Dec 8, 2017

Uh oh!

openshift-ci-robot commented Dec 8, 2017

Uh oh!

stevekuznetsov commented Dec 8, 2017

Uh oh!

soltysh Dec 11, 2017

Choose a reason for hiding this comment

Uh oh!

deads2k Dec 11, 2017

Choose a reason for hiding this comment

Uh oh!

deads2k commented Dec 11, 2017

Uh oh!

openshift-ci-robot commented Dec 11, 2017

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

liggitt commented Dec 12, 2017

Uh oh!

stevekuznetsov commented Dec 12, 2017

Uh oh!

stevekuznetsov commented Dec 12, 2017

Uh oh!

deads2k commented Dec 13, 2017

Uh oh!

stevekuznetsov commented Dec 13, 2017

Uh oh!

Uh oh!