Skip to content

UPSTREAM: 62668: add metrics to cinder volume #19444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2018
Merged

UPSTREAM: 62668: add metrics to cinder volume #19444

merged 1 commit into from
May 2, 2018

Conversation

zetaab
Copy link
Contributor

@zetaab zetaab commented Apr 20, 2018

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2018
@gnufied
Copy link
Member

gnufied commented Apr 20, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2018
@rootfs
Copy link
Member

rootfs commented Apr 30, 2018

/assign @jsafrane for approval

@openshift-ci-robot
Copy link

@rootfs: GitHub didn't allow me to assign the following users: for, approval.

Note that only openshift members and repo collaborators can be assigned.

In response to this:

/assign @jsafrane for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rootfs
Copy link
Member

rootfs commented Apr 30, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2018
@childsb
Copy link
Contributor

childsb commented May 1, 2018

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2018
@zetaab
Copy link
Contributor Author

zetaab commented May 2, 2018

/test extended_conformance_install

@jsafrane
Copy link
Contributor

jsafrane commented May 2, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 428152d into openshift:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@jsafrane jsafrane

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zetaab @gnufied @rootfs @openshift-ci-robot @childsb @jsafrane @openshift-merge-robot