Skip to content

service catalog: updates for upstream v0.1.16 #19568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2018
Merged

service catalog: updates for upstream v0.1.16 #19568

merged 1 commit into from
May 4, 2018

Conversation

jboyd01
Copy link

@jboyd01 jboyd01 commented Apr 30, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2018
@jboyd01 jboyd01 requested review from pmorie and jpeeler April 30, 2018 18:30
@jboyd01
Copy link
Author

jboyd01 commented Apr 30, 2018

/retest

1 similar comment
@jboyd01
Copy link
Author

jboyd01 commented Apr 30, 2018

/retest

@jpeeler jpeeler mentioned this pull request May 1, 2018
Merged
@jpeeler
Copy link

jpeeler commented May 1, 2018 •
edited
Loading

/test service-catalog
v0.1.16 image is available now, so hopefully this passes
CI run: https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_service_catalog/538/console

@jpeeler
Copy link

jpeeler commented May 2, 2018 •
edited
Loading

/test service-catalog
try again, some mirror issues causing test failure
CI run: https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_service_catalog/539/console

@smarterclayton
Copy link
Contributor

/retest

@jpeeler
Copy link

jpeeler commented May 2, 2018 •
edited
Loading

/test service-catalog
e2e fixes added
CI run: https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_service_catalog/548/

@jpeeler
Copy link

jpeeler commented May 2, 2018

Service catalog job passed, the run reported from the bot is outdated (currently catalog tests have been disabled). PR is good to go.

@pmorie
Copy link
Contributor

pmorie commented May 2, 2018

/test service-catalog

@pmorie
Copy link
Contributor

pmorie commented May 2, 2018

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2018
@csrwng
Copy link
Contributor

csrwng commented May 2, 2018

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, jboyd01, pmorie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2018
@jpeeler jpeeler mentioned this pull request May 2, 2018
Merged
@pmorie
Copy link
Contributor

pmorie commented May 2, 2018

/lgtm cancel

@jboyd01 tells me that there are still issues with admission control that need to be worked out.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 2, 2018
@pmorie
Copy link
Contributor

pmorie commented May 2, 2018

/lgtm

@jboyd01 is going to handle the admission issues separately

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jpeeler jpeeler mentioned this pull request May 3, 2018
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jwmatthews jwmatthews mentioned this pull request May 3, 2018
Closed
@stevekuznetsov
Copy link
Contributor

stevekuznetsov commented May 3, 2018 •
edited
Loading

/skip

@jpeeler
Copy link

jpeeler commented May 3, 2018

/test unit

@openshift-merge-robot openshift-merge-robot merged commit 0bf99e3 into openshift:master May 4, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2018 •
edited
Loading

@jboyd01: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/service-catalog e48471b link /test service-catalog
ci/openshift-jenkins/gcp e48471b link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@csrwng csrwng Awaiting requested review from csrwng

@pmorie pmorie Awaiting requested review from pmorie

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@pmorie pmorie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jboyd01 @jpeeler @smarterclayton @pmorie @csrwng @openshift-ci-robot @openshift-bot @stevekuznetsov @openshift-merge-robot