Skip to content

[OCPERT-108] Make advisory urls clickable in the test-report #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: oar-errata-release-flow
Choose a base branch
from
Open

[OCPERT-108] Make advisory urls clickable in the test-report #525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aab7b6
Make advisory urls clickable in the test-report
jhuttana May 22, 2025
79d5b5b
Address review comment
jhuttana May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion oar/core/worksheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ def create_test_report(self):
# update advisory info
ad_cell_value = ""
for k, v in self._cs.get_advisories().items():
ad_cell_value += f"{k}: {util.get_advisory_link(v)}\n"
ad_link = {util.get_advisory_link(v)}
ad_cell_value += f"{k}: {self._report._to_hyperlink(ad_link, ad_link)}\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple =HYPERLINK in the same cell does not work as expected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to use a different solution. See suggestions in #525 (comment).
The same applies also to master branch. See #524 (comment)

self._report.update_advisory_info(ad_cell_value.strip())
logger.info("advisory info is updated")
logger.debug(f"advisory info:\n{ad_cell_value}")
Expand Down