Skip to content

MGMT-20045: Enable LCA deployment via operator bundle in seed creation #62068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mresvanis
Copy link
Contributor

@mresvanis mresvanis commented Feb 26, 2025

This change enables the lifecycle agent operator (LCA) deployment via the OLM operator bundle created in each pipeline when creating the seed SNO.

More details in the description of https://issues.redhat.com/browse/MGMT-20045.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 26, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2025

@mresvanis: This pull request references MGMT-20045 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This change adds the knobs to enable the lifecycle agent operator deployment via the operator bundle created in each pipeline when creating the seed SNO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis mresvanis force-pushed the mgmt-20045-use-lca-oo-bundle branch from cff7314 to 601524a Compare February 26, 2025 13:13
@mresvanis
Copy link
Contributor Author

/test all

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis mresvanis force-pushed the mgmt-20045-use-lca-oo-bundle branch from 601524a to bbe1f7f Compare February 26, 2025 14:15
@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis mresvanis force-pushed the mgmt-20045-use-lca-oo-bundle branch from bbe1f7f to 47c8b14 Compare February 27, 2025 08:49
@mresvanis
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@mresvanis: job(s): /pj-rehearse either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis mresvanis force-pushed the mgmt-20045-use-lca-oo-bundle branch from 47c8b14 to 68e01cf Compare February 27, 2025 11:52
@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis mresvanis force-pushed the mgmt-20045-use-lca-oo-bundle branch 2 times, most recently from 5b6f509 to 185a1df Compare February 28, 2025 10:34
@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis mresvanis force-pushed the mgmt-20045-use-lca-oo-bundle branch from 185a1df to 2556456 Compare February 28, 2025 10:42
@mresvanis
Copy link
Contributor Author

/test all

@mresvanis
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-main-ibi-e2e-flow

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mresvanis: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-lifecycle-agent-release-4.15-ibu-e2e-flow openshift-kni/lifecycle-agent presubmit Ci-operator config changed
pull-ci-openshift-kni-lifecycle-agent-release-4.14-ibu-e2e-flow openshift-kni/lifecycle-agent presubmit Ci-operator config changed
pull-ci-openshift-kni-lifecycle-agent-release-4.17-ibi-e2e-flow openshift-kni/lifecycle-agent presubmit Ci-operator config changed
pull-ci-openshift-kni-lifecycle-agent-release-4.17-ibu-e2e-flow openshift-kni/lifecycle-agent presubmit Ci-operator config changed
pull-ci-openshift-kni-lifecycle-agent-main-ibi-e2e-flow openshift-kni/lifecycle-agent presubmit Ci-operator config changed
pull-ci-openshift-kni-lifecycle-agent-main-ibu-e2e-flow openshift-kni/lifecycle-agent presubmit Ci-operator config changed
pull-ci-openshift-kni-lifecycle-agent-release-4.16-ibu-e2e-flow openshift-kni/lifecycle-agent presubmit Ci-operator config changed
pull-ci-openshift-kni-lifecycle-agent-release-4.18-ibi-e2e-flow openshift-kni/lifecycle-agent presubmit Ci-operator config changed
pull-ci-openshift-kni-lifecycle-agent-release-4.18-ibu-e2e-flow openshift-kni/lifecycle-agent presubmit Ci-operator config changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.16-nightly-4.16-upgrade-from-stable-4.15-image-based-upgrade-e2e-parallel-conformance N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-seedgen-aws-ocp-4-19 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-upgrade-from-stable-4.18-image-based-upgrade-e2e-serial-conformance-baseline N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.17-nightly-4.17-seedgen-aws-ocp-4-17 N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.17-nightly-4.17-upgrade-from-stable-4.16-image-based-upgrade-e2e-parallel-conformance N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-upgrade-from-stable-4.18-image-based-upgrade-e2e-parallel-conformance N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.16-nightly-4.16-upgrade-from-stable-4.15-image-based-upgrade-e2e-parallel-conformance-baseline N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.16-nightly-4.16-image-based-install N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.18-nightly-4.18-upgrade-from-stable-4.17-image-based-upgrade-e2e-serial-conformance N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.18-nightly-4.18-upgrade-from-stable-4.17-image-based-upgrade-e2e-parallel-conformance N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.16-nightly-4.16-upgrade-from-stable-4.15-image-based-upgrade-e2e-serial-conformance N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.15-nightly-4.15-upgrade-from-stable-4.14-image-based-upgrade-e2e-serial-conformance N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.17-nightly-4.17-upgrade-from-stable-4.16-image-based-upgrade-e2e-serial-conformance-baseline N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.16-nightly-4.16-upgrade-from-stable-4.15-image-based-upgrade-e2e-serial-conformance-baseline N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.18-nightly-4.18-upgrade-from-stable-4.17-image-based-upgrade-e2e-serial-conformance-baseline N/A periodic Periodic changed
periodic-ci-openshift-kni-lifecycle-agent-release-4.17-nightly-4.17-upgrade-from-stable-4.16-image-based-upgrade-e2e-serial-conformance N/A periodic Periodic changed

A total of 38 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mresvanis
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-kni-lifecycle-agent-release-4.18-ibi-e2e-flow pull-ci-openshift-kni-lifecycle-agent-release-4.17-ibi-e2e-flow pull-ci-openshift-kni-lifecycle-agent-main-ibu-e2e-flow pull-ci-openshift-kni-lifecycle-agent-release-4.18-ibu-e2e-flow pull-ci-openshift-kni-lifecycle-agent-release-4.17-ibu-e2e-flow pull-ci-openshift-kni-lifecycle-agent-release-4.16-ibu-e2e-flow pull-ci-openshift-kni-lifecycle-agent-release-4.15-ibu-e2e-flow pull-ci-openshift-kni-lifecycle-agent-release-4.14-ibu-e2e-flow

@mresvanis
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-release-4.16-nightly-4.16-upgrade-from-stable-4.15-image-based-upgrade-e2e-parallel-conformance periodic-ci-openshift-kni-lifecycle-agent-release-4.15-nightly-4.15-upgrade-from-stable-4.14-image-based-upgrade-e2e-parallel-conformance periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-upgrade-from-stable-4.18-image-based-upgrade-e2e-parallel-conformance periodic-ci-openshift-kni-lifecycle-agent-release-4.17-nightly-4.17-upgrade-from-stable-4.16-image-based-upgrade-e2e-parallel-conformance periodic-ci-openshift-kni-lifecycle-agent-release-4.18-nightly-4.18-upgrade-from-stable-4.17-image-based-upgrade-e2e-parallel-conformance

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-upgrade-from-stable-4.18-image-based-upgrade-e2e-parallel-conformance-baseline periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-upgrade-from-stable-4.18-image-based-upgrade-e2e-parallel-conformance

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-release-4.16-nightly-4.16-upgrade-from-stable-4.15-image-based-upgrade-e2e-serial-conformance-baseline

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mresvanis mresvanis marked this pull request as ready for review March 3, 2025 09:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2025
@openshift-ci openshift-ci bot requested review from imiller0 and jeff-roche March 3, 2025 09:12
@mresvanis
Copy link
Contributor Author

/cc @eranco74 @tsorya @omertuc

@openshift-ci openshift-ci bot requested review from eranco74, omertuc and tsorya March 3, 2025 09:12
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2025

@mresvanis: This pull request references MGMT-20045 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This change enables the lifecycle agent operator (LCA) deployment via the OLM operator bundle created in each pipeline when creating the seed SNO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

@mresvanis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-release-4.18-nightly-4.18-upgrade-from-stable-4.17-image-based-upgrade-e2e-parallel-conformance 2556456 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-release-4.18-nightly-4.18-upgrade-from-stable-4.17-image-based-upgrade-e2e-parallel-conformance
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-release-4.18-nightly-4.18-upgrade-from-stable-4.17-image-based-upgrade-e2e-parallel-conformance-baseline 2556456 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-release-4.18-nightly-4.18-upgrade-from-stable-4.17-image-based-upgrade-e2e-parallel-conformance-baseline
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-release-4.15-nightly-4.15-upgrade-from-stable-4.14-image-based-upgrade-e2e-serial-conformance-baseline 2556456 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-release-4.15-nightly-4.15-upgrade-from-stable-4.14-image-based-upgrade-e2e-serial-conformance-baseline
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-release-4.16-nightly-4.16-upgrade-from-stable-4.15-image-based-upgrade-e2e-serial-conformance-baseline 2556456 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-release-4.16-nightly-4.16-upgrade-from-stable-4.15-image-based-upgrade-e2e-serial-conformance-baseline
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-upgrade-from-stable-4.18-image-based-upgrade-e2e-parallel-conformance-baseline 2556456 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-upgrade-from-stable-4.18-image-based-upgrade-e2e-parallel-conformance-baseline
ci/rehearse/periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-upgrade-from-stable-4.18-image-based-upgrade-e2e-parallel-conformance 2556456 link unknown /pj-rehearse periodic-ci-openshift-kni-lifecycle-agent-main-nightly-4.19-upgrade-from-stable-4.18-image-based-upgrade-e2e-parallel-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2025

@mresvanis: This pull request references MGMT-20045 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This change enables the lifecycle agent operator (LCA) deployment via the OLM operator bundle created in each pipeline when creating the seed SNO.

More details in the description of https://issues.redhat.com/browse/MGMT-20045.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mresvanis
Copy link
Contributor Author

/pj-rehearse ack

The failed rehearsals are expected and fail irrespective of this change.

@openshift-ci-robot
Copy link
Contributor

@mresvanis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 3, 2025
Copy link
Contributor

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundle change looks good.
I don't understand what created 16 new jobs 😕

@mresvanis
Copy link
Contributor Author

I don't understand what created 16 new jobs 😕

@eranco74 I think this stems from the renaming of the following files to reflect the branch of LCA they are configured to run with:

  • rename from ci-operator/config/openshift-kni/lifecycle-agent/openshift-kni-lifecycle-agent-main__nightly-4.15-upgrade-from-stable-4.14.yaml
    rename to ci-operator/config/openshift-kni/lifecycle-agent/openshift-kni-lifecycle-agent-release-4.15__nightly-4.15-upgrade-from-stable-4.14.yaml
  • rename from ci-operator/config/openshift-kni/lifecycle-agent/openshift-kni-lifecycle-agent-main__nightly-4.16-upgrade-from-stable-4.15.yaml
    rename to ci-operator/config/openshift-kni/lifecycle-agent/openshift-kni-lifecycle-agent-release-4.16__nightly-4.16-upgrade-from-stable-4.15.yaml
  • rename from ci-operator/config/openshift-kni/lifecycle-agent/openshift-kni-lifecycle-agent-main__nightly-4.17-upgrade-from-stable-4.16.yaml
    rename to ci-operator/config/openshift-kni/lifecycle-agent/openshift-kni-lifecycle-agent-release-4.17__nightly-4.17-upgrade-from-stable-4.16.yaml
  • rename from ci-operator/config/openshift-kni/lifecycle-agent/openshift-kni-lifecycle-agent-main__nightly-4.18-upgrade-from-stable-4.17.yaml
    rename to ci-operator/config/openshift-kni/lifecycle-agent/openshift-kni-lifecycle-agent-release-4.18__nightly-4.18-upgrade-from-stable-4.17.yaml

@eranco74
Copy link
Contributor

eranco74 commented Mar 6, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
Copy link
Contributor

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, mresvanis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2a03f06 into openshift:master Mar 6, 2025
45 of 51 checks passed
@mresvanis mresvanis deleted the mgmt-20045-use-lca-oo-bundle branch March 6, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants