Adding rds-core to e2e-ci #62177
Adding rds-core to e2e-ci #62177
Conversation
Signed-off-by: Vishnu Challa <[email protected]>
openshift-ci
bot
added
the
approved
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/assign @josecastillolema |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@vishnuchalla: job(s): pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node either don't exist or were not found to be affected, and cannot be rehearsed |
...ud-bulldozer/e2e-benchmarking/rds-core/cloud-bulldozer-e2e-benchmarking-rds-core-commands.sh
Outdated
Show resolved
Hide resolved
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@vishnuchalla: job(s): pull-ci-cloud-bulldozer-e2e-benchmarking-master-e2e-rds-core-single-node either don't exist or were not found to be affected, and cannot be rehearsed |
...perator/config/cloud-bulldozer/e2e-benchmarking/cloud-bulldozer-e2e-benchmarking-master.yaml
Outdated
Show resolved
Hide resolved
vishnuchalla
force-pushed
the
rds-core
branch
from
413179b to
8255107
Compare
|
/pj-rehearse network-access-allowed |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@vishnuchalla: PR author isn't allowed to allow network access rehearsals. This must be done by a different member of the |
vishnuchalla
force-pushed
the
rds-core
branch
from
8255107 to
a56a238
Compare
vishnuchalla
force-pushed
the
rds-core
branch
from
a56a238 to
a4b15d2
Compare
|
/pj-rehearse network-access-allowed |
|
@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Vishnu Challa <[email protected]>
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master_metal-e2e-rds-core-mno |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-cloud-bulldozer-e2e-benchmarking-master_metal-e2e-rds-core-mno |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
| @@ -62,6 +66,7 @@ EOF | |||
|
|
|||
| sleep 60 | |||
| kubectl wait --for jsonpath='{.status.updatedMachineCount}'="$(oc get node --no-headers -l node-role.kubernetes.io/worker= | wc -l)" --timeout=30m mcp worker | |||
| oc adm wait-for-stable-cluster --minimum-stable-period=2m --timeout=20m | |||
There was a problem hiding this comment.
Not a blocking stuff, but maybe this command should better go here instead? https://github.com/openshift/release/blob/master/ci-operator/step-registry/openshift-qe/installer/bm/day2/perf-profile/rds-core/openshift-qe-installer-bm-day2-perf-profile-rds-core-commands.sh#L65
Minor nit, the worker-spk label is not needed here. |
|
/pj-rehearse ack |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
removed
the
rehearsals-ack
| @@ -9,13 +9,17 @@ if [ ${BAREMETAL} == "true" ]; then | |||
| SSH_ARGS="-i /bm/jh_priv_ssh_key -oStrictHostKeyChecking=no -oUserKnownHostsFile=/dev/null" | |||
| bastion="$(cat /bm/address)" | |||
| # Copy over the kubeconfig | |||
| ssh ${SSH_ARGS} root@$bastion "cat ${KUBECONFIG_PATH}" > /tmp/kubeconfig | |||
| if [ ! -f "${SHARED_DIR}/kubeconfig" ]; then | |||
There was a problem hiding this comment.
@vishnuchalla are you confident that this change won't impact the daily jobs that consume the label step?
There was a problem hiding this comment.
Yes we are sure on this. Check bm-deploy step, which copies kubeconfig to shared directory at the end.
| @@ -60,7 +64,7 @@ spec: | |||
| userLevelNetworking: false | |||
| EOF | |||
|
|
|||
| sleep 60 | |||
| oc adm wait-for-stable-cluster --minimum-stable-period=2m --timeout=20m | |||
| kubectl wait --for jsonpath='{.status.updatedMachineCount}'="$(oc get node --no-headers -l node-role.kubernetes.io/worker= | wc -l)" --timeout=30m mcp worker | |||
There was a problem hiding this comment.
I think the wait for machineset should go before the wait for cluster operators health.
Also, please just for consistency parametrize the same variables as in: https://github.com/openshift/release/blob/master/ci-operator/step-registry/openshift-qe/cluster-health/openshift-qe-cluster-health-ref.yaml
There was a problem hiding this comment.
cluster health doesn't have anything to do with machineset wait right. Do you really think the order matters? I did n't parameterize the health check times as they are used in this single step as an adhoc thing and did not see a value in doing so.
There was a problem hiding this comment.
The machineset wait will always finish before the CO check, I just think the order doesn't make sense.
There was a problem hiding this comment.
okay. Updated as suggested.
Signed-off-by: Vishnu Challa <[email protected]>
|
[REHEARSALNOTIFIER]
A total of 34 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: josecastillolema, vishnuchalla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse ack |
|
@vishnuchalla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
Description
Adding rds-core to e2e-ci
JIRA: https://issues.redhat.com/browse/PERFSCALE-3705
Testing
Need to verify it through this PR rehearsal