Skip to content

[th/dpu-operator-handle-errors] improve error handling in "dpu-operator-e2e-tests-workflow-tests-commands.sh" script #65391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[th/dpu-operator-handle-errors] improve error handling in "dpu-operator-e2e-tests-workflow-tests-commands.sh" script #65391

merged 1 commit into from
May 28, 2025

Conversation

thom311
Copy link
Contributor

@thom311 thom311 commented May 27, 2025

  • The "$return_code" variable may be bogus or empty. Redirect the error message from test to /dev/null.
  • Handle error from curl commands to die with a message.

@thom311
dpu: improve error handling in "dpu-operator-e2e-tests-workflow-tests…
07020b2 
…-commands.sh" script

- The "$return_code" variable may be bogus or empty. Redirect
  the error message from `test` to /dev/null.
- Handle error from curl commands to die with a message.
@openshift-ci openshift-ci bot requested review from dgoodwin and stbenjam May 27, 2025 18:03
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@thom311: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-dpu-operator-main-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.21-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.20-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.19-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.18-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.17-make-e2e-test openshift/dpu-operator presubmit Registry content changed
pull-ci-openshift-dpu-operator-release-4.16-make-e2e-test openshift/dpu-operator presubmit Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@thom311
Copy link
Contributor Author

thom311 commented May 27, 2025

/pj-rehearse pull-ci-openshift-dpu-operator-main-make-e2e-test

@openshift-ci-robot
Copy link
Contributor

@thom311: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@thom311
Copy link
Contributor Author

thom311 commented May 27, 2025

/pj-rehease ack

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 27, 2025

@thom311: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/dpu-operator/main/make-e2e-test 07020b2 link unknown /pj-rehearse pull-ci-openshift-dpu-operator-main-make-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bn222
Copy link
Contributor

bn222 commented May 27, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, thom311

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@thom311
Copy link
Contributor Author

thom311 commented May 28, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@thom311: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 78a6b09 into openshift:master May 28, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

@bn222 bn222

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thom311 @openshift-ci-robot @bn222