Skip to content

Add certificate check to deprov vsphere #65399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Add certificate check to deprov vsphere #65399

merged 1 commit into from
May 28, 2025

Conversation

jcpowermac
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from dgoodwin and xueqzhan May 27, 2025 21:00
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@rvanderp3
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2025
@rvanderp3
Copy link
Contributor

/lgtm

feel free to drop the hold when ready

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@jcpowermac
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcpowermac jcpowermac force-pushed the check-ssl-certificate-vsphere branch from 59921bb to 2c68fed Compare May 27, 2025 23:37
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@jcpowermac
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcpowermac jcpowermac force-pushed the check-ssl-certificate-vsphere branch from 2c68fed to b650e14 Compare May 28, 2025 11:12
@jcpowermac
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcpowermac jcpowermac force-pushed the check-ssl-certificate-vsphere branch from b650e14 to 73323a0 Compare May 28, 2025 15:57
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jcpowermac: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-main-e2e-vsphere-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-vsphere-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-vsphere-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-vsphere-ovn openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.13-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.12-e2e-vsphere-ovn-etcd-scaling openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-vsphere-ovn-dualstack-primaryv6 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-vsphere-ovn-dualstack-primaryv6 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-vsphere-ovn-dualstack-primaryv6 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.19-e2e-vsphere-ovn-dualstack-primaryv6 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.18-e2e-vsphere-ovn-dualstack-primaryv6 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-vsphere-ovn-dualstack-primaryv6 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-vsphere-ovn-dualstack-primaryv6 openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.21-e2e-vsphere-ovn-upi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.20-e2e-vsphere-ovn-upi openshift/origin presubmit Registry content changed

A total of 1257 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jcpowermac
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2025

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@jcpowermac: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 28, 2025
@jcpowermac
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5af1270 into openshift:master May 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

Assignees

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcpowermac @rvanderp3 @openshift-ci-robot