Start CI, fixing an error on Ruby 2.5. #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change for
Gemfile.lock
.According to latest revert [1] by an error on openshift/origin [2], the reason looks related to new version of
mysql2
andactiverecord
.So, let's do a baby step.
Ideally one day, it is good to add unit test cases for
run.sh
and to be run byopenshift/origin
, to this repository's CI.What I want is to run
run.sh
on Ruby 2.5.Running
run.sh
on Ruby 2.5, that shows warnings like this.But I think that this PR is still okay for the first step.
[1] #67
[2] openshift/origin#18522 (comment)