Skip to content

enable guest_hook_path in remote config #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

snir911
Copy link
Contributor

@snir911 snir911 commented Jun 3, 2024

No description provided.

@snir911 snir911 requested review from jensfr and bpradipt June 3, 2024 11:17
@openshift-ci openshift-ci bot requested review from gkurz and pmores June 3, 2024 11:18
@bpradipt
Copy link
Contributor

bpradipt commented Jun 3, 2024

@snir911 this needs to be updated as well - https://github.com/openshift/sandboxed-containers-operator/blob/devel/config/peerpods/mc-40-kata-remote-config.yaml
ex

butane -d ./local mc-remote-butane.conf > mc-40-kata-remote-config.yaml

This is where it gets used - https://github.com/openshift/sandboxed-containers-operator/blob/devel/controllers/openshift_controller.go#L2155

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Verified the config using

cat mc-40-kata-remote-config.yaml | yq '.spec.config.storage.files[].contents.source'  |  sed -e 's/data:;base64,//g' | base64 -d | gzip -d

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@bpradipt
Copy link
Contributor

bpradipt commented Jun 3, 2024

@snir911 you'll need to create a cherry-pick of this into release-1.6 branch

git cherry-pick -sx ..

@bpradipt bpradipt merged commit ac99746 into openshift:devel Jun 3, 2024
2 of 4 checks passed
Copy link

openshift-ci bot commented Jun 3, 2024

@snir911: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check 440680a link false /test check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants