Fixes for annotation handling related to pod vm image creation and deletion #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are scenarios where an annotation may exist and adding a new annotation will fail if we don't use overwrite. Additionally delete the annotation on image deletion Fixes: #KATA-3117 Signed-off-by: Pradipta Banerjee <[email protected]>
There are scenarios where an annotation may exist and adding a new annotation will fail if we don't use overwrite. Fixes: #KATA-3117 Signed-off-by: Pradipta Banerjee <[email protected]>
Use AMI instead of image where relevant as AWS uses AMI. Signed-off-by: Pradipta Banerjee <[email protected]>
littlejawa
approved these changes
Jun 6, 2024
gkurz
reviewed
Jun 6, 2024
gkurz
approved these changes
Jun 6, 2024
|
/test images |
bpradipt
changed the title
|
/test images |
|
@bpradipt: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.