Update existing MC in createMcFromFile() #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content of MachineConfig objects created by the operator isn't an invariant. For example, the MachineConfig that installs the CRI-O configuration for peer pods changed recently to use the regular shim v2 binary instead of the `-tp` one (see daa16fe). The operator should update such MachineConfig objects created by a previous deployment. Note that `client.Update()` requires the object to have a valid resource version to succeed. Fixes: KATA-3295 Signed-off-by: Greg Kurz <[email protected]>
pmores
approved these changes
Sep 3, 2024
|
@gkurz: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description of the problem which is fixed/What is the use case
Upgrade of OSC should set the same configuration of CRI-O and kata for peer pods as a first time deployment, i.e. don't keep previous MachineConfig objects the content of which might be obsolete.
Fixes: KATA-3295
- What I did
Force the update of existing MachineConfig objects.
- How to verify it
/etc/crio/crio.conf.d/50-kata-remotefile on kata enabled nodes should be exactly :