-
Notifications
You must be signed in to change notification settings - Fork 55
KATA-3270: pod overhead for peer pods reduce actual worker capacity #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@balintTobik: This pull request references KATA-3270 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hi @balintTobik. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @balintTobik !
Thanks for working on that. I've commented and hopefully clarified what we want to achieved for now, i.e. use different overhead values for kata
and kata-remote
.
Also all commits should have a message and a valid Signed-off-by: tag.
Please address the comments in your local repo and force push to this PR.
dda4db6
to
dbc252d
Compare
Signed-off-by: Balint Tobik <[email protected]>
dbc252d
to
40322ec
Compare
Hi @gkurz! |
@balintTobik: This pull request references KATA-3270 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @balintTobik ! Thanks for this work.
I've pushed another commit on top of your PR that does some trivial polishing and suggests a description for your commit. I will squash at merge time.
Now we'll ask for some feedback from @vvoronko.
3b321b5
to
448ee53
Compare
Rever memory overhead of `kata` to 350 megs. Commit text example : The pod overhead of peer pods is expected to be lower than regular kata pods. Use a different set of values for the `kata` and `kata-remote` runtime classe, like upstream kata does. Current numbers for `kata` are kept. New numbers for `kata-remote` are taken from upstream.The numbers can probably be refined some more through experiments. Signed-off-by: Greg Kurz <[email protected]>
448ee53
to
ce52f59
Compare
@balintTobik: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
I should have squashed the patches at merge time but I forgot... never mind. |
…overhead" This reverts commit 22a5690, reversing changes made to 4325a09. Balint's patch will be re-applied with a commit log that I forgot to squash when I merged the PR. Signed-off-by: Greg Kurz <[email protected]>
- Description of the problem which is fixed/What is the use case
Peer pods' overhead reduce actual worker capacity, however most of the RAM/CPU allocated in cloud instance.
Fixes: KATA-3270
- What I did
Operator create 'kata-remote' runtime class with a specific and lower overhead, like in upstream.
- How to verify it
- Description for the changelog
Use separate pod's overhead related constants for kata and peer pods.
[EDIT from Greg: adapted description to final version]