-
Notifications
You must be signed in to change notification settings - Fork 55
baremetal-coco: tdx: Add DCAP deployment #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baremetal-coco: tdx: Add DCAP deployment #493
Conversation
Hi @fidencio. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Please, pretty please, let's have it properly tested before merged. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestions
scripts/install-helpers/baremetal-coco/intel-dcap/registration-ds.yaml.in
Outdated
Show resolved
Hide resolved
414eca1
to
986a66b
Compare
986a66b
to
994ffb8
Compare
540b31a
to
be52ca5
Compare
We just missed doing this when we added the deployment of the intel device plugins operator. Signed-off-by: Fabiano Fidêncio <[email protected]>
aa7df0f
to
f7c5567
Compare
@bpradipt, this one is finally ready to be reviewed (and hopefully, merged!) |
f7c5567
to
7d291bf
Compare
f3315a1
to
beae6fb
Compare
scripts/install-helpers/baremetal-coco/intel-dcap/registration-ds.yaml.in
Outdated
Show resolved
Hide resolved
As we're relying on `jq` for a few cases, let's just make sure this is required by moving its check to right after the `oc ` check. Signed-off-by: Fabiano Fidêncio <[email protected]>
Rename the set_aa_kbc_params_for_kata_agent to set_kernel_params_for_kata_agent, as later in this series we'll also use this function to set the agent.https_proxy and agent.no_proxy parameters, which are needed in order to properly pull images inside the guest on a cluster running behind proxies. Signed-off-by: Fabiano Fidêncio <[email protected]>
beae6fb
to
cd0a112
Compare
Let's set up a per-cluster PCCS, meaning: * a single service that chaces all the DCAP collateral requests * "indirect" DCAP registration, which stores the encrypted platform keys on PCCS * PCCS database on a dedicated node, where the admin knows what to back up (if needed) This is required in order to have attestation working for TDX, be it using DCAP directly or ITA. Signed-off-by: Fabiano Fidêncio <[email protected]> Signed-off-by: Mikko Ylinen <[email protected]>
cd0a112
to
921fe2f
Compare
This is needed as that's the only way for the agent running inside the guest to know about proxies. Signed-off-by: Fabiano Fidêncio <[email protected]>
921fe2f
to
5e82849
Compare
oc apply -f ns.yaml || return 1 | ||
|
||
oc project intel-dcap | ||
oc adm policy add-scc-to-user privileged -z default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the dcap need to run in a privileged mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does, unfortunately.
For this, I think we can just leave it as it is for now, as soon enough we should not need to run DCAP / PCCS / QGS from inside a container, with everything being packaged as part of the virt sig.
I started testing this version of the PR, as it is ... let's see how it goes ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @fidencio !
I started testing this version of the PR, as it is ... let's see how it goes ...
This PR could potentially skip CI since nothing calls this code but I have no control on that AFAIK. I'll thus start CI when you are done with your testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Finished the tests on my side, on an environment that's not behind proxies and it works as expected. |
@fidencio: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Please, see each commit message for a better explanation of what's being done.
This is out for early testing, and there are a few things to consider:
I will give instructions to @bpradipt, and give him access to a clean SNO cluster, so he can go ahead and give it a try during the time I will be off.
KNOWN ISSUES: