KATA-3493: toml file should include image annotations

[balintTobik]

- Description of the problem which is fixed/What is the use case
current default annotations doesn't include "image", it should be patched during operator deployment to be like:
enable_annotations = ["default_vcpus", "default_memory", "machine_type", "image", "default_gpus", "gpu_model" ]

Fixes: KATA-3493

- What I did
Extended hypervisor.remote's enable_annotation field with "image", "default_gpus" and "gpu_model" values.
Generated them to mc-40-kata-remote-config.yaml machineconfig.

- How to verify it
Operator should populate these new values to /opt/kata/configuration-remote.toml file on kata nodes.

- Description for the changelog
Add "image", "default_gpus" and "gpu_model" to enable_annotation field in configuration.toml and regenarate mc-40-kata-remote-config.yaml.

[openshift-ci-robot]

@balintTobik: This pull request references KATA-3493 which is a valid jira issue.

In response to this:

- Description of the problem which is fixed/What is the use case
current default annotations doesn't include "image", it should be patched during operator deployment to be like:
enable_annotations = ["default_vcpus", "default_memory", "machine_type", "image", "default_gpus", "gpu_model" ]

Fixes: KATA-3493

- What I did
Extended hypervisor.remote's enable_annotation field with "image", "default_gpus" and "gpu_model" values.
Generated them to mc-40-kata-remote-config.yaml machineconfig.

- How to verify it
Operator should populate these new values to /opt/kata/configuration-remote.toml file on kata nodes.

- Description for the changelog
Add "image", "default_gpus" and "gpu_model" to enable_annotation field in configuration.toml and regenarate mc-40-kata-remote-config.yaml.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@balintTobik: This pull request references KATA-3493 which is a valid jira issue.

In response to this:

- Description of the problem which is fixed/What is the use case
current default annotations doesn't include "image", it should be patched during operator deployment to be like:
enable_annotations = ["default_vcpus", "default_memory", "machine_type", "image", "default_gpus", "gpu_model" ]

Fixes: KATA-3493

- What I did
Extended hypervisor.remote's enable_annotation field with "image", "default_gpus" and "gpu_model" values.
Generated them to mc-40-kata-remote-config.yaml machineconfig.

- How to verify it
Operator should populate these new values to /opt/kata/configuration-remote.toml file on kata nodes.

- Description for the changelog
Add "image", "default_gpus" and "gpu_model" to enable_annotation field in configuration.toml and regenarate mc-40-kata-remote-config.yaml.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @balintTobik. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[gkurz]

Hi @balintTobik ! Thanks for working on that.

Overall change looks good. One issue though is that the PR contains a merge commit which is best avoided : we only want to see your changes there, not the various things you had to do in order to keep your PR in sync with the base branch.

The typical way of syncing pending work on top of the base branch is to git rebase in your local repo and force push to the PR. Please refresh your PR so that it just have the KATA-3493: update configuration-remote.toml commit (and address the newline nit on the way).

[gkurz]

/ok-to-test

[openshift-ci]

@balintTobik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gkurz]

/lgtm

Thanks @balintTobik !

[gkurz]

Pre-merged tested by myself :

• deployed this PR on OCP 4.17
• created KataConfig with peer pods enabled
• checked annotations are listed in kata configuration

$ oc debug --quiet node/worker0 -- chroot /host grep enable_annotations /opt/kata/configuration-remote.toml
enable_annotations = ["default_vcpus", "default_memory", "machine_type", "image", "default_gpus", "gpu_model"]