gcp: PODVM_IMAGE_NAME is the right name #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The annotation is LATEST_IMAGE_ID but the configmap value is _NAME. I would prefer to not touch on the metadata now, since the metadata.annotation is the same for all providers. Signed-off-by: Beraldo Leal <[email protected]>
littlejawa
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Looking at the commit that introduced it: it seems you were using the right name everywhere else, it's just this one.
/lgtm
Thanks @beraldoleal !
|
@beraldoleal: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The annotation is LATEST_IMAGE_ID but the configmap value is _NAME. I would prefer to not touch on the metadata now, since the metadata.annotation is the same for all providers.