-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: install script not x86 windows; add warning for arm64 windows #19911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Nice, I didn't know bun worked on arm windows. I wonder if it is because microsoft made a decent emulator now or if just really lucky with how the binary is made. I wonder if we should make it throw a warning though, to tell user that it has a higher chance of random issues. |
The installed
If you want, I can do this too for sure! I do wonder what it would take to actually get a native build of bun on arm64 tho 👀 (gh does have windows-11-arm runners now, but I assume its more so JSC/zig stuff?) |
So after trying out this windows arm (emulated on apple silicon macbook), I haven't found any clear issues that windows bun in general doesn't already have. But would like input from @Electroid (or other team members) if should be documented further, just have it working with warning, or block install like this pr will do. Oh and consider building it natively, but that seems to be an interesting task. |
I'd be fine with allowing Windows ARM as long as we update the issue template to make sure we know when users are emulating it:
Right now I believe this will have WoA users writing x64 since it is 64-bit. |
We can edit the script to be a simpler & show the type "$([Environment]::OSVersion | ForEach-Object VersionString) $env:PROCESSOR_ARCHITECTURE"
# normal: Microsoft Windows NT 10.0.26100.0 AMD64
# arm: Microsoft Windows NT 10.0.26100.0 ARM64 On this similar thinking, the crash report I'd also like to have it show this too (ie |
If you can guide me where that is done I can try to make it happen, but it might take longer. 😅 |
2c79738
to
e958d9a
Compare
Ok, rebase from UI breaks verification. ty GitHub |
What does this PR do?
This PR "fixes" the install script on Windows by correctly checking whether the script is ran on x64 instead of ARM64.
That said, bun does seem to work fine on ARM64, including building bundles but ofc it's probably luck of the draw. Crosscompiling on x64 and running on ARM64 doesn't work however...
How did you verify your code works?
Ran
-not (((Get-CimInstance Win32_ComputerSystem)).SystemType -match "x64-based")
on Powershell on Win11 on ARM64On a friends machine, that IS on x64,

related #9824